chore: migrate from formula to cask#2
Conversation
GoReleaser deprecated formula publishing in favor of macOS-only casks. Add tap_migrations.json so existing 'shelltime' formula users auto-migrate to the cask on upgrade, remove the obsolete Formula/shelltime.rb (GoReleaser now publishes Casks/shelltime.rb), and note in the README that the tap is macOS-only with the curl installer for Linux. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the Shelltime formula, updates the README to clarify that the Homebrew tap is now a macOS-only Cask, and adds a tap_migrations.json file. The feedback advises removing the tap_migrations.json file because it uses an invalid tap name and is incorrect for formula-to-cask migrations. Additionally, it is recommended to add migration instructions in the README for existing macOS users transitioning from the formula to the cask.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| { | ||
| "shelltime": "shelltime" | ||
| } |
There was a problem hiding this comment.
The tap_migrations.json file should be removed entirely.
- Invalid Tap Name: The value
"shelltime"is not a valid Homebrew tap name. Homebrew tap names must follow theuser/repoformat (e.g.,shelltime/tap). Using an invalid tap name will cause Homebrew to raise aTapSpecificationErrorand crash/fail duringbrew updateorbrew tapfor your users. - Incorrect Usage:
tap_migrations.jsonis designed to redirect formulas/casks that have moved to a different tap (e.g., fromhomebrew/coretoshelltime/tap). It cannot be used to migrate a formula to a cask within the same tap.
Since there is no built-in automatic formula-to-cask migration mechanism in Homebrew for third-party taps, you should delete this file and instead instruct existing users to manually reinstall the package as a cask.
| > [!NOTE] | ||
| > The Homebrew tap is distributed as a **macOS-only Cask**. On Linux, install with: | ||
| > ```bash | ||
| > curl -sSL https://shelltime.xyz/i | bash | ||
| > ``` |
There was a problem hiding this comment.
Since you are migrating from a formula to a cask, existing macOS users who previously installed shelltime as a formula will not be automatically upgraded to the cask. They will need to uninstall the formula and install the cask.
It would be highly beneficial to include these migration instructions in the note so existing users know how to transition. For example:
> [!NOTE]
> The Homebrew tap is distributed as a **macOS-only Cask**.
> - **On Linux**, install with:
> ```bash
> curl -sSL https://shelltime.xyz/i | bash
> ```
> - **On macOS (existing formula users)**, migrate to the cask by running:
> ```bash
> brew uninstall shelltime
> brew install shelltime
> ```
|
@claude ultrareview |
1 participant
Why
GoReleaser deprecated Homebrew formula publishing in favor of macOS-only casks (companion change: shelltime/cli#292). This tap needs to switch so existing users auto-migrate.
Changes
tap_migrations.json({ "shelltime": "shelltime" }) — tells Homebrew the oldshelltimeformula is now a cask, sobrew upgradeauto-migrates existing installs.Formula/shelltime.rb— obsolete; GoReleaser will now publishCasks/shelltime.rbon the next CLI release.Ordering note
Casks/shelltime.rbonly appears after the next CLI release runs the updated GoReleaser config. Merge/release shelltime/cli#292 first (or together) so there isn't a window where the formula is removed but the cask hasn't been published yet.🤖 Generated with Claude Code