p575 Unify description field#5902
Open
akleshchev wants to merge 2 commits into
Open
Conversation
41a06dd to
172bc55
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes the validation rules for inventory/landmark description fields so they can contain newlines while still disallowing the pipe (|) character (which is used as a legacy delimiter and can break notecard-style serialization). It also hardens legacy inventory item stream import/export to better preserve multi-line descriptions by escaping/unescaping newlines.
Changes:
- Introduces/renames a text validator to allow ASCII + newline while excluding
|, and wires it up via XUIprevalidatorattributes. - Updates the validator error string for the new “newline + ASCII (no pipe)” rule.
- Updates
LLInventoryItemlegacy stream import/export to escape/unescape newlines and reassemble multi-linedescfields split across lines.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| indra/newview/skins/default/xui/en/strings.xml | Adds a new validator error string for the no-pipe, newline-allowing validator. |
| indra/newview/skins/default/xui/en/sidepanel_item_info.xml | Switches the description field to a newline-allowing, no-pipe validator. |
| indra/newview/skins/default/xui/en/panel_landmark_info.xml | Switches landmark notes to the newline-allowing, no-pipe validator. |
| indra/newview/skins/default/xui/en/floater_create_landmark.xml | Switches landmark creation notes to the newline-allowing, no-pipe validator. |
| indra/llui/lltextvalidate.h | Renames the exported validator symbol to the new “newline + no pipe” variant. |
| indra/llui/lltextvalidate.cpp | Implements the “newline + ASCII excluding pipe” validator and registers it as ascii_with_newline_no_pipe. |
| indra/llinventory/llinventory.cpp | Escapes newlines on export, reassembles multi-line desc on import, and unescapes back to the original content. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
172bc55 to
f052c24
Compare
maxim-productengine
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Landmarks permit newlines in the description, but also permit pipes (which breaks notecards), other items permit neither. Unified requirements.
P.S. I will create a ticket for CopyInventoryFromNotecard separately and a bit later.