Cleanups postgres connections logic#456
Open
kunrex wants to merge 8 commits intosdslabs:bl4ze/devfrom
Open
Conversation
sukhman-sukh
requested changes
Apr 2, 2026
| log.Infoln("Attempting to connect to postgres as postgres super user...") | ||
|
|
||
| dsn := fmt.Sprintf("user=%s dbname=%s sslmode=%s", "postgres", "postgres", "disable") | ||
| dsn := fmt.Sprintf("user=%s dbname=%s host=%s port=%s sslmode=%s", "postgres", "postgres", configuration.Host, configuration.Port, "disable") |
Collaborator
There was a problem hiding this comment.
you can add user adn dbname from config too
Author
There was a problem hiding this comment.
this is intended, at this point the db and user dont exist, so have to connect to postgres database as postgres first to create them.
| password := utils.PromptSecret("Enter postgres super user password (leave blank if none):") | ||
|
|
||
| dsn := fmt.Sprintf("user=%s password=%s dbname=%s sslmode=%s", "postgres", password, "postgres", "disable") | ||
| dsn := fmt.Sprintf("user=%s password=%s dbname=%s host=%s port=%s sslmode=%s", "postgres", password, "postgres", configuration.Host, configuration.Port, "disable") |
| "--if-exists", | ||
| backupFile, | ||
| ) | ||
| backupFile) |
Collaborator
|
REST LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Relied a lot on exec to terminate connections which wasn't preferable in the long run and especially when containerisation has to be done.
there are things that cannot be done without exec: specifically: pg_dump and pg_restore so those will have to be installed.