fix: improve keyboard shortcuts (and non working help dialog)#413
Open
DeepSpace2 wants to merge 1 commit intoscribble-rs:masterfrom
Open
fix: improve keyboard shortcuts (and non working help dialog)#413DeepSpace2 wants to merge 1 commit intoscribble-rs:masterfrom
DeepSpace2 wants to merge 1 commit intoscribble-rs:masterfrom
Conversation
DeepSpace2
force-pushed
the
fix-improve-keyboard-shortcuts
branch
from
1824731 to
10dbd9a
Compare
DeepSpace2
changed the title
DeepSpace2
force-pushed
the
fix-improve-keyboard-shortcuts
branch
from
10dbd9a to
bcb3a86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #355
Fixes help dialog not opening at all ("invalid invocation" console error)
Keybindings defined in a single location in the codebase. Keys are no longer hardcoded across backend and frontend code. This allows keys to be user-configurable in the future.
Shows keybindings in tooltip messages
Adds missing "undo" keybinding to help dialog
Significantly reduces text overload in help dialog
Caveat: As I removed format specifiers from a translatable string (
"switch-pencil-sizes"), users of non-English/Hebrew languages will see raw%suntil these languages will be updated. I wasn't comfortable enough to use machine translations for this.