fix: only inject provider env vars when credentials are configured#141
Draft
khaledsulayman wants to merge 1 commit intosallyom:mainfrom
Draft
fix: only inject provider env vars when credentials are configured#141khaledsulayman wants to merge 1 commit intosallyom:mainfrom
khaledsulayman wants to merge 1 commit intosallyom:mainfrom
Conversation
…loses sallyom#140) The Deployment manifest unconditionally injected secretKeyRef env vars for all providers, but the Secret only contained keys for the selected provider. OpenClaw's secrets reloader treated the referenced-but-empty vars as fatal, causing CrashLoopBackOff when switching providers. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deploymentManifest()conditional, matching the existing conditional logic insecretManifest()Test plan
npm run buildpassesnpm run lintpassesnpm test— all k8s-manifests tests pass (22/22), including new regression test