Skip to content

Warn when -J falls back from Content-Disposition#740

Merged
ryanfowler merged 1 commit into
mainfrom
warn-on-j-fallback
Jun 10, 2026
Merged

Warn when -J falls back from Content-Disposition#740
ryanfowler merged 1 commit into
mainfrom
warn-on-j-fallback

Conversation

@ryanfowler

Copy link
Copy Markdown
Owner

Summary

  • Emit a warning when --remote-header-name is requested but no usable Content-Disposition filename is available
  • Keep the fallback behavior intact, using the URL path or host filename as before
  • Update docs and add unit/integration coverage for missing and invalid header cases

Testing

  • cargo fmt
  • cargo clippy --locked --all-targets --all-features -- -D warnings
  • cargo test --all-features --test cli --test formatting --test grpc --test http --test network --test terminal --test update --test websocket -- --test-threads=1
  • Focused unit and HTTP integration tests for -O -J fallback behavior

@ryanfowler ryanfowler merged commit 31f6612 into main Jun 10, 2026
4 checks passed
@ryanfowler ryanfowler deleted the warn-on-j-fallback branch June 10, 2026 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant