Merge #539: Test walletdisplayaddress

df26039 Add integration test for walletdisplayaddress RPC (Abeeujah)

Pull request description:

  `signer__wallet_display_address` tests `walletdisplayaddress` RPC call mocking an external signer.

  The test mocks a Hardware Wallet (HWW) interaction by:
  1. Creating a temporary shell script that acts as an external signer.
  2. Handling the 'enumerate', 'getdescriptors', and 'displayaddress' commands expected by Bitcoin Core.
  3. Spawning a node with the `-signer` argument pointing to this mock.
  4. Creating a descriptor-based wallet with `external_signer` enabled.
  5. Asserting that calling `wallet_display_address` returns the expected address from the mock signer.

  Heavily Inspired by [wallet_signer.py](https://github.com/bitcoin/bitcoin/blob/master/test/functional/wallet_signer.py)

ACKs for top commit:
  jamillambert:
    ACK df26039
  tcharding:
    ACK df26039

Tree-SHA512: 6956528c25a812388f36fc1b5126afb2b735974cd78f7b82ac9696a5ceb961d76a69f56911adc19d0d76bfec43320cd00af2a1af425083f9bf5d6b9f3f14cf44

Author: tcharding

client/src/client_sync/v22/mod.rs

@@ -144,6 +144,7 @@ crate::impl_client_v17__add_multisig_address!();
 crate::impl_client_v17__backup_wallet!();
 crate::impl_client_v17__bump_fee!();
 crate::impl_client_v21__create_wallet!();
+crate::impl_client_v22__create_wallet!();
 crate::impl_client_v17__dump_priv_key!();
 crate::impl_client_v17__dump_wallet!();
 crate::impl_client_v17__encrypt_wallet!();

client/src/client_sync/v22/wallet.rs

@@ -44,3 +44,50 @@ macro_rules! impl_client_v22__wallet_display_address {
         }
     };
 }
+
+/// Implements Bitcoin Core JSON-RPC API method `createwallet`.
+#[macro_export]
+macro_rules! impl_client_v22__create_wallet {
+    () => {
+        impl Client {
+            /// Creates a wallet with external_signer=true.
+            ///
+            /// > createwallet "wallet_name" ( disable_private_keys blank "passphrase" avoid_reuse descriptors load_on_startup external_signer )
+            /// >
+            /// > Creates and loads a new wallet.
+            /// >
+            /// > Arguments:
+            /// > 1. wallet_name             (string, required) The name for the new wallet. If this is a path, the wallet will be created at the path location.
+            /// > 2. disable_private_keys    (boolean, optional, default=false) Disable the possibility of private keys (only watchonlys are possible in this mode).
+            /// > 3. blank                   (boolean, optional, default=false) Create a blank wallet. A blank wallet has no keys or HD seed. One can be set using sethdseed.
+            /// > 4. passphrase              (string, optional) Encrypt the wallet with this passphrase.
+            /// > 5. avoid_reuse             (boolean, optional, default=false) Keep track of coin reuse, and treat dirty and clean coins differently with privacy considerations in mind.
+            /// > 6. descriptors             (boolean, optional, default=true) Create a native descriptor wallet. The wallet will use descriptors internally to handle address creation
+            /// > 7. load_on_startup         (boolean, optional) Save wallet name to persistent settings and load on startup. True to add wallet to startup list, false to remove, null to leave unchanged.
+            /// > 8. external_signer         (boolean, optional, default=false) Use an external signer such as a hardware wallet. Requires -signer to be configured. Wallet creation will fail if keys cannot be fetched. Requires disable_private_keys and descriptors set to true.
+            pub fn create_wallet_external_signer(&self, wallet: &str) -> Result<CreateWallet> {
+                let disable_private_keys = true;
+                let blank = false;
+                let passphrase = String::new();
+                let avoid_reuse = false;
+                let descriptors = true;
+                let load_on_startup = false;
+                let external_signer = true;
+
+                self.call(
+                    "createwallet",
+                    &[
+                        wallet.into(),
+                        disable_private_keys.into(),
+                        blank.into(),
+                        passphrase.into(),
+                        avoid_reuse.into(),
+                        descriptors.into(),
+                        load_on_startup.into(),
+                        external_signer.into(),
+                    ],
+                )
+            }
+        }
+    };
+}

client/src/client_sync/v23/mod.rs

@@ -145,6 +145,7 @@ crate::impl_client_v17__abort_rescan!();
 crate::impl_client_v17__add_multisig_address!();
 crate::impl_client_v17__backup_wallet!();
 crate::impl_client_v17__bump_fee!();
+crate::impl_client_v22__create_wallet!();
 crate::impl_client_v23__create_wallet!();
 crate::impl_client_v17__dump_priv_key!();
 crate::impl_client_v17__dump_wallet!();

client/src/client_sync/v24/mod.rs

@@ -146,6 +146,7 @@ crate::impl_client_v17__abort_rescan!();
 crate::impl_client_v17__add_multisig_address!();
 crate::impl_client_v17__backup_wallet!();
 crate::impl_client_v17__bump_fee!();
+crate::impl_client_v22__create_wallet!();
 crate::impl_client_v23__create_wallet!();
 crate::impl_client_v17__dump_priv_key!();
 crate::impl_client_v17__dump_wallet!();

client/src/client_sync/v25/mod.rs

@@ -147,6 +147,7 @@ crate::impl_client_v17__abort_rescan!();
 crate::impl_client_v17__add_multisig_address!();
 crate::impl_client_v17__backup_wallet!();
 crate::impl_client_v17__bump_fee!();
+crate::impl_client_v22__create_wallet!();
 crate::impl_client_v23__create_wallet!();
 crate::impl_client_v17__dump_priv_key!();
 crate::impl_client_v17__dump_wallet!();

client/src/client_sync/v26/mod.rs

@@ -158,6 +158,7 @@ crate::impl_client_v17__abort_rescan!();
 crate::impl_client_v17__add_multisig_address!();
 crate::impl_client_v17__backup_wallet!();
 crate::impl_client_v17__bump_fee!();
+crate::impl_client_v22__create_wallet!();
 crate::impl_client_v23__create_wallet!();
 crate::impl_client_v17__dump_priv_key!();
 crate::impl_client_v17__dump_wallet!();

client/src/client_sync/v27/mod.rs

@@ -154,6 +154,7 @@ crate::impl_client_v17__abort_rescan!();
 crate::impl_client_v17__add_multisig_address!();
 crate::impl_client_v17__backup_wallet!();
 crate::impl_client_v17__bump_fee!();
+crate::impl_client_v22__create_wallet!();
 crate::impl_client_v23__create_wallet!();
 crate::impl_client_v17__dump_priv_key!();
 crate::impl_client_v17__dump_wallet!();

client/src/client_sync/v28/mod.rs

@@ -155,6 +155,7 @@ crate::impl_client_v17__abort_rescan!();
 crate::impl_client_v17__add_multisig_address!();
 crate::impl_client_v17__backup_wallet!();
 crate::impl_client_v17__bump_fee!();
+crate::impl_client_v22__create_wallet!();
 crate::impl_client_v23__create_wallet!();
 crate::impl_client_v28__create_wallet_descriptor!();
 crate::impl_client_v17__dump_priv_key!();

client/src/client_sync/v29/mod.rs

@@ -162,6 +162,7 @@ crate::impl_client_v17__abort_rescan!();
 crate::impl_client_v17__add_multisig_address!();
 crate::impl_client_v17__backup_wallet!();
 crate::impl_client_v17__bump_fee!();
+crate::impl_client_v22__create_wallet!();
 crate::impl_client_v23__create_wallet!();
 crate::impl_client_v28__create_wallet_descriptor!();
 crate::impl_client_v17__dump_priv_key!();

client/src/client_sync/v30/mod.rs

@@ -159,6 +159,7 @@ crate::impl_client_v17__abandon_transaction!();
 crate::impl_client_v17__abort_rescan!();
 crate::impl_client_v17__backup_wallet!();
 crate::impl_client_v17__bump_fee!();
+crate::impl_client_v22__create_wallet!();
 crate::impl_client_v23__create_wallet!();
 crate::impl_client_v28__create_wallet_descriptor!();
 crate::impl_client_v17__encrypt_wallet!();