You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Implement `create_wallet_external_signer` for creating wallets that
can interact with external signers e.g. hardware wallet.
Add an integration test `signer__wallet_display_address` to verify
the functionality of the `walletdisplayaddress` RPC call when using an
external signer.
The test mocks a Hardware Wallet (HWW) interaction by:
1. Creating a temporary shell script that acts as an external signer.
2. Handling the 'enumerate', 'getdescriptors', and 'displayaddress'
commands expected by Bitcoin Core.
3. Spawning a node with the `-signer` argument pointing to this mock.
4. Creating a descriptor-based wallet with `external_signer` enabled.
5. Asserting that calling `wallet_display_address` returns the expected
address from the mock signer.
Drop all `UNTESTED` for `walletdisplayaddress` RPC
/// > 1. wallet_name (string, required) The name for the new wallet. If this is a path, the wallet will be created at the path location.
61
+
/// > 2. disable_private_keys (boolean, optional, default=false) Disable the possibility of private keys (only watchonlys are possible in this mode).
62
+
/// > 3. blank (boolean, optional, default=false) Create a blank wallet. A blank wallet has no keys or HD seed. One can be set using sethdseed.
63
+
/// > 4. passphrase (string, optional) Encrypt the wallet with this passphrase.
64
+
/// > 5. avoid_reuse (boolean, optional, default=false) Keep track of coin reuse, and treat dirty and clean coins differently with privacy considerations in mind.
65
+
/// > 6. descriptors (boolean, optional, default=true) Create a native descriptor wallet. The wallet will use descriptors internally to handle address creation
66
+
/// > 7. load_on_startup (boolean, optional) Save wallet name to persistent settings and load on startup. True to add wallet to startup list, false to remove, null to leave unchanged.
67
+
/// > 8. external_signer (boolean, optional, default=false) Use an external signer such as a hardware wallet. Requires -signer to be configured. Wallet creation will fail if keys cannot be fetched. Requires disable_private_keys and descriptors set to true.
0 commit comments