Add Object::GetOwnPropertyAccessor

One of the tests is commented out until SetAccessorProperty is implemented

Author: georgyangelov

ext/v8/object.cc

@@ -14,6 +14,7 @@ namespace rr {
       defineMethod("CreateDataProperty", &CreateDataProperty).
       defineMethod("DefineOwnProperty", &DefineOwnProperty).
       defineMethod("GetPropertyAttributes", &GetPropertyAttributes).
+      defineMethod("GetOwnPropertyDescriptor", &GetOwnPropertyDescriptor).
 
       store(&Class);
   }
@@ -137,6 +138,16 @@ namespace rr {
     ));
   }
 
+  VALUE Object::GetOwnPropertyDescriptor(VALUE self, VALUE r_context, VALUE key) {
+    Object object(self);
+    Locker lock(object);
+
+    return Value::Maybe(object.getIsolate(), object->GetOwnPropertyDescriptor(
+      Context(r_context),
+      *rr::String(key)
+    ));
+  }
+
   Object::operator VALUE() {
     Isolate isolate(getIsolate());
     Locker lock(isolate);

ext/v8/object.h

@@ -18,6 +18,7 @@ namespace rr {
     static VALUE CreateDataProperty(VALUE self, VALUE r_context, VALUE key, VALUE value);
     static VALUE DefineOwnProperty(int argc, VALUE* argv, VALUE self);
     static VALUE GetPropertyAttributes(VALUE self, VALUE r_context, VALUE key);
+    static VALUE GetOwnPropertyDescriptor(VALUE self, VALUE r_context, VALUE key);
 
     inline Object(VALUE value) : Ref<v8::Object>(value) {}
     inline Object(v8::Isolate* isolate, v8::Handle<v8::Object> object) : Ref<v8::Object>(isolate, object) {}

spec/c/function_spec.rb

@@ -63,8 +63,8 @@ def call(info)
     end
 
     let(:data) { V8::C::Object::New(@isolate) }
-    let(:callback) { FunctionCallback.new @isolate}
-    let(:fn) { V8::C::Function::New(@isolate, callback, data)}
+    let(:callback) { FunctionCallback.new @isolate }
+    let(:fn) { V8::C::Function::New(@isolate, callback, data) }
 
     before do
       expect(fn.Call(@ctx.Global(), ["world"]).Utf8Value()).to eql "ohai world"

spec/c/object_spec.rb

@@ -114,6 +114,83 @@
     end
   end
 
+  describe '#GetOwnPropertyDescriptor' do
+    it 'can read the descriptor of a data property' do
+      o = V8::C::Object.New(@isolate)
+      key = V8::C::String.NewFromUtf8(@isolate, 'foo')
+      data = V8::C::String.NewFromUtf8(@isolate, 'data')
+
+      expect(o.DefineOwnProperty(@ctx, key, data, V8::C::PropertyAttribute::DontEnum)).to be_successful
+
+      maybe = o.GetOwnPropertyDescriptor(@ctx, key)
+      expect(maybe).to be_successful
+
+      descriptor = maybe.FromJust
+      value = descriptor.Get(@ctx, V8::C::String.NewFromUtf8(@isolate, 'value'))
+      writable = descriptor.Get(@ctx, V8::C::String.NewFromUtf8(@isolate, 'writable'))
+      get = descriptor.Get(@ctx, V8::C::String.NewFromUtf8(@isolate, 'get'))
+      set = descriptor.Get(@ctx, V8::C::String.NewFromUtf8(@isolate, 'set'))
+      configurable = descriptor.Get(@ctx, V8::C::String.NewFromUtf8(@isolate, 'configurable'))
+      enumerable = descriptor.Get(@ctx, V8::C::String.NewFromUtf8(@isolate, 'enumerable'))
+
+      expect(value).to strict_eq data
+
+      expect(writable).to be_successful
+      expect(writable.FromJust.Value).to be true
+
+      expect(get).to be_successful
+      expect(get.FromJust).to be_a V8::C::Undefined
+
+      expect(set).to be_successful
+      expect(set.FromJust).to be_a V8::C::Undefined
+
+      expect(configurable).to be_successful
+      expect(configurable.FromJust.Value).to be true
+
+      expect(enumerable).to be_successful
+      expect(enumerable.FromJust.Value).to be false
+    end
+
+    # it 'can read the descriptor of an accessor property' do
+    #   o = V8::C::Object.New(@isolate)
+    #   key = V8::C::String.NewFromUtf8(@isolate, 'foo')
+    #   data = V8::C::String.NewFromUtf8(@isolate, 'data')
+    #
+    #   getter = V8::C::Function.New @isolate, proc { }, V8::C::Object::New(@isolate)
+    #   setter = V8::C::Function.New @isolate, proc { }, V8::C::Object::New(@isolate)
+    #
+    #   expect(o.SetAccessorProperty(@ctx, key, getter, setter)).to be_successful
+    #
+    #   maybe = o.GetOwnPropertyDescriptor(@ctx, key)
+    #   expect(maybe).to be_successful
+    #
+    #   descriptor = maybe.FromJust
+    #   value = descriptor.Get(@ctx, V8::C::String.NewFromUtf8(@isolate, 'value'))
+    #   writable = descriptor.Get(@ctx, V8::C::String.NewFromUtf8(@isolate, 'writable'))
+    #   get = descriptor.Get(@ctx, V8::C::String.NewFromUtf8(@isolate, 'get'))
+    #   set = descriptor.Get(@ctx, V8::C::String.NewFromUtf8(@isolate, 'set'))
+    #   configurable = descriptor.Get(@ctx, V8::C::String.NewFromUtf8(@isolate, 'configurable'))
+    #   enumerable = descriptor.Get(@ctx, V8::C::String.NewFromUtf8(@isolate, 'enumerable'))
+    #
+    #   expect(value).to be_successful
+    #
+    #   expect(writable).to be_successful
+    #   expect(writable.FromJust.Value).to be true
+    #
+    #   expect(get).to be_successful
+    #   expect(get.FromJust).to be_a V8::C::Undefined
+    #
+    #   expect(set).to be_successful
+    #   expect(set.FromJust).to be_a V8::C::Undefined
+    #
+    #   expect(configurable).to be_successful
+    #   expect(configurable.FromJust.Value).to be true
+    #
+    #   expect(enumerable).to be_successful
+    #   expect(enumerable.FromJust.Value).to be true
+    # end
+  end
+
   # TODO: Enable this when the methods are implemented in the extension
   # it 'can retrieve all property names' do
   #   o = V8::C::Object.New