Add Object::GetPropertyAttributes

Author: georgyangelov

ext/v8/enum.h

@@ -16,6 +16,15 @@ namespace rr {
     operator T() {
       return RTEST(value) ? (T)NUM2INT(value) : defaultValue;
     }
+
+    class Maybe : public rr::Maybe {
+    public:
+      Maybe(v8::Maybe<T> maybe) {
+        if (maybe.IsJust()) {
+          just(INT2FIX((int)maybe.FromJust()));
+        }
+      }
+    };
   };
 
   inline void DefineEnums() {

ext/v8/object.cc

@@ -13,6 +13,7 @@ namespace rr {
       defineMethod("SetAccessor", &SetAccessor).
       defineMethod("CreateDataProperty", &CreateDataProperty).
       defineMethod("DefineOwnProperty", &DefineOwnProperty).
+      defineMethod("GetPropertyAttributes", &GetPropertyAttributes).
 
       store(&Class);
   }
@@ -126,6 +127,16 @@ namespace rr {
     ));
   }
 
+  VALUE Object::GetPropertyAttributes(VALUE self, VALUE r_context, VALUE key) {
+    Object object(self);
+    Locker lock(object);
+
+    return Enum<v8::PropertyAttribute>::Maybe(object->GetPropertyAttributes(
+      Context(r_context),
+      *Name(key)
+    ));
+  }
+
   Object::operator VALUE() {
     Isolate isolate(getIsolate());
     Locker lock(isolate);

ext/v8/object.h

@@ -17,6 +17,7 @@ namespace rr {
 
     static VALUE CreateDataProperty(VALUE self, VALUE r_context, VALUE key, VALUE value);
     static VALUE DefineOwnProperty(int argc, VALUE* argv, VALUE self);
+    static VALUE GetPropertyAttributes(VALUE self, VALUE r_context, VALUE key);
 
     inline Object(VALUE value) : Ref<v8::Object>(value) {}
     inline Object(v8::Isolate* isolate, v8::Handle<v8::Object> object) : Ref<v8::Object>(isolate, object) {}

ext/v8/rr.h

@@ -17,9 +17,10 @@ inline VALUE not_implemented(const char* message) {
 }
 
 #include "class_builder.h"
-#include "enum.h"
 
 #include "maybe.h"
+#include "enum.h"
+
 #include "equiv.h"
 #include "bool.h"
 #include "uint32_t.h"

spec/c/object_spec.rb

@@ -103,6 +103,17 @@
     end
   end
 
+  describe '#GetPropertyAttributes' do
+    it 'can get the set attributes' do
+      o = V8::C::Object.New(@isolate)
+      key = V8::C::String.NewFromUtf8(@isolate, 'foo')
+      data = V8::C::String.NewFromUtf8(@isolate, 'data')
+
+      expect(o.DefineOwnProperty(@ctx, key, data, V8::C::PropertyAttribute::DontEnum)).to be_successful
+      expect(o.GetPropertyAttributes(@ctx, key)).to eq_just V8::C::PropertyAttribute::DontEnum
+    end
+  end
+
   # TODO: Enable this when the methods are implemented in the extension
   # it 'can retrieve all property names' do
   #   o = V8::C::Object.New