Skip to content
This repository was archived by the owner on Dec 4, 2023. It is now read-only.

Commit c46dcba

Browse files
committed
Use last good version before build error
Using bisect, I was able to find that the build error was introduced in v8/v8@5bbca54, so let's use the version before that one while we wait for upstream to merge the patch (https://bugs.chromium.org/p/v8/issues/detail?id=10708)
1 parent 5c7c6e3 commit c46dcba

4 files changed

Lines changed: 8 additions & 5 deletions

File tree

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
### v8.4.255.0 - 2020-07-15
2+
3+
* Update upstream v8 version to 8.4.255.0
4+
15
### v7.3.495.0 - 2020-04-14
26

37
* Update upstream v8 version to 7.3.495.0

ext/libv8/builder.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ def setup_python!
6565
# then this will be 4.5.95
6666
#
6767
def source_version
68-
Libv8::V8_MINOR_VERSION
68+
Libv8::VERSION.gsub(/\.[^.]+$/, '')
6969
end
7070

7171
##
@@ -84,7 +84,7 @@ def setup_build_deps!
8484

8585
Dir.chdir('v8') do
8686
system 'git fetch origin'
87-
unless system "git checkout branch-heads/#{source_version}"
87+
unless system "git checkout #{source_version}"
8888
fail "unable to checkout source for v8 #{source_version}"
8989
end
9090
system "gclient sync" or fail "could not sync v8 build dependencies"

lib/libv8/version.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
module Libv8
2-
V8_MINOR_VERSION = "8.4"
3-
VERSION = "8.4.371.0"
2+
VERSION = "8.4.255.0"
43
end

vendor/depot_tools

Submodule depot_tools updated from 3229d94 to 9d9199a

0 commit comments

Comments
 (0)