Skip to content
This repository was archived by the owner on Dec 4, 2023. It is now read-only.

Commit 5c7c6e3

Browse files
committed
update to 8.4.371.19
This requires changing our checkout strategy to check out the branch-heads branch (as documented at https://v8.dev/docs/version-numbers) instead of using the 8.4.371 branch, which never gets patches (it's always locked to 8.4.371.0). We could also specify the v8 patch version manually, and i'm open to doing that, just wanted to do this to get it working.
1 parent fcf04ce commit 5c7c6e3

3 files changed

Lines changed: 5 additions & 4 deletions

File tree

ext/libv8/builder.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ def setup_python!
6565
# then this will be 4.5.95
6666
#
6767
def source_version
68-
Libv8::VERSION.gsub(/\.[^.]+$/, '')
68+
Libv8::V8_MINOR_VERSION
6969
end
7070

7171
##
@@ -84,7 +84,7 @@ def setup_build_deps!
8484

8585
Dir.chdir('v8') do
8686
system 'git fetch origin'
87-
unless system "git checkout #{source_version}"
87+
unless system "git checkout branch-heads/#{source_version}"
8888
fail "unable to checkout source for v8 #{source_version}"
8989
end
9090
system "gclient sync" or fail "could not sync v8 build dependencies"

lib/libv8/version.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
module Libv8
2-
VERSION = "7.3.495.0"
2+
V8_MINOR_VERSION = "8.4"
3+
VERSION = "8.4.371.0"
34
end

vendor/depot_tools

Submodule depot_tools updated from 9c06201 to 3229d94

0 commit comments

Comments
 (0)