Fix Markdown blockquote parsing by st0012 · Pull Request #1627 · ruby/rdoc

st0012 · 2026-02-28T21:20:04Z

Summary

Two fixes to the BlockQuoteRaw rule in the PEG grammar:

Separate blockquotes (separated by an unquoted blank line) were merged into one. Now only blank lines prefixed with > continue the blockquote, so an unquoted blank line ends it.
Lazy continuation was consuming block-level elements (headings, list markers, code fences) that should break out of the blockquote. Added negative lookaheads for these elements.

Ref: #1550 (comment)

matzbot · 2026-02-28T21:21:04Z

🚀 Preview deployment available at: https://31657d5e.rdoc-6cd.pages.dev (commit: 2d74d02)

Copilot

Pull request overview

Fixes blockquote parsing so that (1) unquoted blank lines terminate a blockquote instead of being absorbed, and (2) “lazy continuation” does not incorrectly consume certain block-level constructs that should break out of a blockquote.

Changes:

Update BlockQuoteRaw grammar to require >-prefixed blank lines for blockquote continuation.
Add negative lookaheads to prevent lazy continuation from consuming headings/list markers/code fences.
Add regression tests for separate blockquotes and lazy-continuation breakouts.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
`test/rdoc/rdoc_markdown_test.rb`	Adds tests covering separated blockquotes and ensuring list/heading/fence starters break out of lazy continuation.
`lib/rdoc/markdown.rb`	Updates generated parser implementation of `BlockQuoteRaw` to match the revised grammar.
`lib/rdoc/markdown.kpeg`	Updates the PEG grammar for `BlockQuoteRaw` to correctly terminate on unquoted blank lines and block certain lazy continuations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

lib/rdoc/markdown.kpeg

lib/rdoc/markdown.rb

Copilot · 2026-04-08T14:36:03Z

test/rdoc/rdoc_markdown_test.rb

+
+    assert_equal expected, doc
+  end
+


There are tests toggling @parser.github = false for fenced code blocks, but the new blockquote/code-fence interaction isn’t covered in that mode. Add a regression test that sets @parser.github = false and verifies that a ``` line does not force a blockquote to terminate (since fences aren’t block-level without the GitHub extension).

Suggested change

def test_parse_block_quote_no_lazy_continuation_for_code_fence_non_github

@parser.github = false

doc = parse <<~BLOCK_QUOTE

> foo

```

code

```

BLOCK_QUOTE

expected =

doc(

block(

para("foo\n```\ncode\n```")))

assert_equal expected, doc

end

kou · 2026-04-08T14:38:37Z

lib/rdoc/markdown.kpeg

                 (( ">" " "? Line:l { a << l } )
-                  ( !">" !@BlankLine Line:c { a << c } )*
-                  ( @BlankLine:n { a << n } )*
+                  ( !">" !@BlankLine !AtxStart !Bullet !Enumerator !Ticks3 Line:c { a << c } )*


Kinda yes. It's displayed that way but # is stripped. It's a bug I'll address separately in Preserve # prefix for unresolved cross-references #1676

The table is included on the same time as x in the quote block. I tried to fix it but it's a much more complex fix so I think it deserves a separate PR.

- Headings (`# foo`), bullet lists, ordered lists, and code fences now break out of a blockquote instead of being lazily continued. - Unquoted blank lines end the blockquote; only `>`-prefixed blank lines continue it. - Heading lookahead uses `!(AtxStart @Spacechar)` so `#no-space` text (not a valid heading) is correctly kept inside the blockquote. - Code fence lookahead is gated behind `&{ github? }` so it only applies when the GitHub extension is enabled, matching `CodeFence`. Ref: #1627

When `#name` doesn't resolve to a method, the cross-reference handler was stripping the `#` and returning just the name. Now the original text including `#` is restored when the lookup fails. This fixes rendering of text like `#no-space-heading` in Markdown paragraphs, where the `#` was silently dropped in the final HTML.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

kou

+1

st0012 force-pushed the fix-blockquote-lazy-continuation branch from 1959fd1 to d658309 Compare February 28, 2026 21:23

st0012 added the bug label Feb 28, 2026

st0012 force-pushed the fix-blockquote-lazy-continuation branch 4 times, most recently from 6f54b65 to c168d42 Compare February 28, 2026 22:33

st0012 changed the title ~~Fix blockquote lazy continuation and preserve Markdown newlines~~ Fix blockquote parsing and soft line break rendering to match GFM Feb 28, 2026

st0012 changed the title ~~Fix blockquote parsing and soft line break rendering to match GFM~~ Improve Markdown blockquote rendering Feb 28, 2026

st0012 force-pushed the fix-blockquote-lazy-continuation branch 2 times, most recently from 3d620eb to 0706cd1 Compare March 1, 2026 12:14

st0012 changed the title ~~Improve Markdown blockquote rendering~~ Fix Markdown blockquote parsing Mar 1, 2026

st0012 marked this pull request as ready for review March 1, 2026 12:15

st0012 force-pushed the fix-blockquote-lazy-continuation branch from 0706cd1 to 652ed49 Compare April 4, 2026 14:14

kou requested a review from Copilot April 8, 2026 14:28

Copilot started reviewing on behalf of kou April 8, 2026 14:29 View session

Copilot AI reviewed Apr 8, 2026

View reviewed changes

kou reviewed Apr 8, 2026

View reviewed changes

st0012 added 2 commits April 9, 2026 16:43

st0012 mentioned this pull request Apr 9, 2026

Preserve # prefix for unresolved cross-references #1676

Open

st0012 force-pushed the fix-blockquote-lazy-continuation branch from 652ed49 to 2d74d02 Compare April 9, 2026 16:16

st0012 requested a review from Copilot April 9, 2026 17:10

Copilot started reviewing on behalf of st0012 April 9, 2026 17:10 View session

Copilot AI reviewed Apr 9, 2026

View reviewed changes

kou approved these changes Apr 10, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Markdown blockquote parsing#1627

Fix Markdown blockquote parsing#1627
st0012 wants to merge 2 commits intomasterfrom
fix-blockquote-lazy-continuation

st0012 commented Feb 28, 2026 •

edited

Loading

Uh oh!

matzbot commented Feb 28, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Apr 8, 2026

Uh oh!

kou Apr 8, 2026

Uh oh!

st0012 Apr 9, 2026

Uh oh!

kou Apr 10, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

kou left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

+  def test_parse_block_quote_no_lazy_continuation_for_code_fence_non_github
+    @parser.github = false
+    doc = parse <<~BLOCK_QUOTE
+      > foo
+      ```
+      code
+      ```
+    BLOCK_QUOTE
+    expected =
+      doc(
+        block(
+          para("foo\n```\ncode\n```")))
+    assert_equal expected, doc
+  end

	Block = @BlankLine*
	( BlockQuote
	\| Verbatim
	\| CodeFence
	\| Table
	\| Note
	\| Reference
	\| HorizontalRule
	\| Heading
	\| OrderedList
	\| BulletList
	\| DefinitionList
	\| HtmlBlock
	\| StyleBlock
	\| Para
	\| Plain )

Conversation

st0012 commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

matzbot commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

kou Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

st0012 Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

kou Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

kou left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

st0012 commented Feb 28, 2026 •

edited

Loading

matzbot commented Feb 28, 2026 •

edited

Loading