Merge branch 'batch-create-fails-with-parent-context-rollback' into 3.0-preview

# Conflicts:
#	Tests/CoreDataRepositoryTests/CRUDRepositoryTests.swift

Author: roanutil

Sources/CoreDataRepository/CoreDataRepository+CRUD.swift

@@ -17,11 +17,18 @@ extension CoreDataRepository {
     ) async -> Result<Model, CoreDataError> {
         await context.performInScratchPad(schedule: .enqueued) { [context] scratchPad in
             let object = Model.ManagedModel(context: scratchPad)
+            let tempObjectId = object.objectID
             try item.updating(managed: object)
             try scratchPad.save()
             try context.performAndWait {
                 context.transactionAuthor = transactionAuthor
-                try context.save()
+                do {
+                    try context.save()
+                } catch {
+                    let parentContextObject = context.object(with: tempObjectId)
+                    context.delete(parentContextObject)
+                    throw error
+                }
                 context.transactionAuthor = nil
             }
             try scratchPad.obtainPermanentIDs(for: [object])

Tests/CoreDataRepositoryTests/CRUDRepositoryTests.swift

@@ -31,6 +31,31 @@ final class CRUDRepositoryTests: CoreDataXCTestCase {
         try verify(transactionAuthor: transactionAuthor, timeStamp: historyTimeStamp)
     }
 
+    func testCreateFailure() async throws {
+        let historyTimeStamp = Date()
+        let transactionAuthor: String = #function
+        let movie = Movie(id: UUID(), title: "Create Success", releaseDate: Date(), boxOffice: 100)
+        var existingMovie = try await repositoryContext().perform(schedule: .immediate) {
+            let object = try ManagedMovie(context: self.repositoryContext())
+            try movie.updating(managed: object)
+            try self.repositoryContext().save()
+            return try Movie(managed: object)
+        }
+        var tempResultMovie = existingMovie
+        XCTAssertNotNil(tempResultMovie.url)
+        tempResultMovie.url = nil
+        XCTAssertNoDifference(tempResultMovie, movie)
+
+        try await verify(existingMovie)
+
+        let result: Result<Movie, CoreDataError> = try await repository()
+            .create(movie, transactionAuthor: transactionAuthor)
+        guard case .failure = result else {
+            XCTFail("Expecting a failed result")
+            return
+        }
+    }
+
     func testReadSuccess() async throws {
         let movie = Movie(id: UUID(), title: "Read Success", releaseDate: Date(), boxOffice: 100)
         let createdMovie: Movie = try await repositoryContext().perform(schedule: .immediate) {

Tests/CoreDataRepositoryTests/Movie.swift

@@ -72,16 +72,16 @@ extension ManagedMovie {
         desc.name = "ManagedMovie"
         desc.managedObjectClassName = NSStringFromClass(ManagedMovie.self)
         desc.properties = [
-            iDDescription,
+            idDescription,
             titleDescription,
             releaseDateDescription,
             boxOfficeDescription,
         ]
-        desc.uniquenessConstraints = [[iDDescription]]
+        desc.uniquenessConstraints = [[idDescription]]
         return desc
     }()
 
-    private static var iDDescription: NSAttributeDescription {
+    private static var idDescription: NSAttributeDescription {
         let desc = NSAttributeDescription()
         desc.name = "id"
         desc.attributeType = .UUIDAttributeType