Fix batch create failure test without performing a rollback on parent context for all scratchpad failures

batch-create-fails-with-parent-context-rollback

Author: roanutil

Sources/CoreDataRepository/CoreDataRepository+CRUD.swift

@@ -17,11 +17,18 @@ extension CoreDataRepository {
     ) async -> Result<Model, CoreDataError> {
         await context.performInScratchPad(schedule: .enqueued) { [context] scratchPad in
             let object = Model.ManagedModel(context: scratchPad)
+            let tempObjectId = object.objectID
             try item.updating(managed: object)
             try scratchPad.save()
             try context.performAndWait {
                 context.transactionAuthor = transactionAuthor
-                try context.save()
+                do {
+                    try context.save()
+                } catch {
+                    let parentContextObject = context.object(with: tempObjectId)
+                    context.delete(parentContextObject)
+                    throw error
+                }
                 context.transactionAuthor = nil
             }
             try scratchPad.obtainPermanentIDs(for: [object])

Sources/CoreDataRepository/Internal/NSManagedObjectContext+Scratchpad.swift

@@ -21,19 +21,16 @@ extension NSManagedObjectContext {
         } catch let error as CoreDataError {
             await scratchPad.perform {
                 scratchPad.rollback()
-                scratchPad.parent?.rollback()
             }
             return .failure(error)
         } catch let error as CocoaError {
             await scratchPad.perform {
                 scratchPad.rollback()
-                scratchPad.parent?.rollback()
             }
             return .failure(.cocoa(error))
         } catch let error as NSError {
             await scratchPad.perform {
                 scratchPad.rollback()
-                scratchPad.parent?.rollback()
             }
             return .failure(CoreDataError.unknown(error))
         }