fix: scope notification deduplication by type#944
Conversation
- Updated findDuplicate to include type filter - Added composite index suggestion - Added mixed-type unit test - Closes rinafcode#822
|
@larryjay007 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
Kindly resolve conflict. |
|
conflict resolved |
|
@RUKAYAT-CODER hi, please review, thanks. |
|
Great job so far There’s just one blocker — the workflow is failing. Could you take a look and fix it so all checks pass? Happy to review again once that’s done. |
|
Alright i will do that right away. |
|
workflow still failing. |
|
Hi @RUKAYAT-CODER , here is what i realized, the core fix for deduplication by type + unit test is done. The remaining typecheck errors are from missing dependencies in other modules (unrelated to this PR). Happy to help if needed. |
|
Check passed. please review. |
|
Thank you for contributing to the project. |
2 participants
Description
Fixed deduplication to scope by notification type so EMAIL and PUSH with same content are both delivered.
Changes
findDuplicate()WHERE clause to includetypeRelated Issue
Closes #822