[packaging] Make polars installation optional#3684
Open
vkarak wants to merge 3 commits into
Open
Conversation
Signed-off-by: Vasileios Karakasis <vkarak@gmail.com>
996f3f9 to
1a77edd
Compare
Contributor
Author
|
@dmargala With this you will be able to |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3684 +/- ##
==========================================
- Coverage 91.91% 91.90% -0.02%
==========================================
Files 62 62
Lines 13772 13779 +7
==========================================
+ Hits 12659 12663 +4
- Misses 1113 1116 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Converting it back to draft; trying to understand why the CI doesn't pick |
Contributor
Author
|
It seems the |
Signed-off-by: Vasileios Karakasis <vkarak@gmail.com>
Signed-off-by: Vasileios Karakasis <vkarak@gmail.com>
cccfc9e to
6aad161
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces an extra called
no-analyticsthat if passed, it will skip thepolarsdependency. However, this dependency is needed ifRFM_ENABLE_RESULTS_STORAGEis set. We expand the validation check in the CLI for this. Also to avoid failures in lightweight installations, polars is only imported in the functions that is needed.Finally, this PR introduces also documentation improvements.
Future note:
polarswill likely be completely removed from dependencies.Closes #3676.