Skip to content

Commit c713445

Browse files
authored
Merge pull request #71 from clue-labs/deps
Lock minimum dependencies and work around circular dependency for tests
2 parents d54ae9a + da93592 commit c713445

4 files changed

Lines changed: 10 additions & 8 deletions

File tree

.travis.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ matrix:
2121
sudo: false
2222

2323
install:
24-
- composer install --no-interaction
25-
24+
- COMPOSER_ROOT_VERSION=`git describe --abbrev=0` composer install --no-interaction
25+
2626
script:
2727
- vendor/bin/phpunit --coverage-text

README.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,10 +108,12 @@ More details about version upgrades can be found in the [CHANGELOG](CHANGELOG.md
108108
## Tests
109109

110110
To run the test suite, you first need to clone this repo and then install all
111-
dependencies [through Composer](http://getcomposer.org):
111+
dependencies [through Composer](http://getcomposer.org).
112+
Because the test suite contains some circular dependencies, you may have to
113+
manually specify the root package version like this:
112114

113115
```bash
114-
$ composer install
116+
$ COMPOSER_ROOT_VERSION=`git describe --abbrev=0` composer install
115117
```
116118

117119
To run the test suite, go to the project root and run:

composer.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@
77
"php": ">=5.3.0",
88
"react/cache": "~0.4.0|~0.3.0",
99
"react/event-loop": "^1.0 || ^0.5 || ^0.4 || ^0.3.5",
10+
"react/promise": "^2.1 || ^1.2.1",
11+
"react/promise-timer": "^1.2",
1012
"react/socket": "^1.0 || ^0.8 || ^0.7 || ^0.6 || ^0.5 || ^0.4.4",
11-
"react/stream": "^1.0 || ^0.7 || ^0.6 || ^0.5 || ^0.4.5",
12-
"react/promise": "~2.1|~1.2",
13-
"react/promise-timer": "~1.1"
13+
"react/stream": "^1.0 || ^0.7 || ^0.6 || ^0.5 || ^0.4.5"
1414
},
1515
"require-dev": {
1616
"phpunit/phpunit": "^5.0 || ^4.8.10"

tests/Query/TimeoutExecutorTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ public function testRejectsPromiseWhenWrappedRejects()
7676

7777
public function testWrappedWillBeCancelledOnTimeout()
7878
{
79-
$this->executor = new TimeoutExecutor($this->wrapped, 0.001, $this->loop);
79+
$this->executor = new TimeoutExecutor($this->wrapped, 0, $this->loop);
8080

8181
$cancelled = 0;
8282

0 commit comments

Comments
 (0)