Skip to content

Commit da93592

Browse files
committed
Use COMPOSER_ROOT_VERSION to support circular dependency to root
We currently have a cyclic dependency between react/socket and react/dns which causes the test setup to fail or pick outdated versions otherwise.
1 parent 22f8e7b commit da93592

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

.travis.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ matrix:
2121
sudo: false
2222

2323
install:
24-
- composer install --no-interaction
25-
24+
- COMPOSER_ROOT_VERSION=`git describe --abbrev=0` composer install --no-interaction
25+
2626
script:
2727
- vendor/bin/phpunit --coverage-text

README.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,10 +108,12 @@ More details about version upgrades can be found in the [CHANGELOG](CHANGELOG.md
108108
## Tests
109109

110110
To run the test suite, you first need to clone this repo and then install all
111-
dependencies [through Composer](http://getcomposer.org):
111+
dependencies [through Composer](http://getcomposer.org).
112+
Because the test suite contains some circular dependencies, you may have to
113+
manually specify the root package version like this:
112114

113115
```bash
114-
$ composer install
116+
$ COMPOSER_ROOT_VERSION=`git describe --abbrev=0` composer install
115117
```
116118

117119
To run the test suite, go to the project root and run:

0 commit comments

Comments
 (0)