Skip to content

RDKB-64133: Allow restoreConfig in business devices#355

Open
pavankumar464 wants to merge 10 commits into
developfrom
bug/RDKB-64133
Open

RDKB-64133: Allow restoreConfig in business devices#355
pavankumar464 wants to merge 10 commits into
developfrom
bug/RDKB-64133

Conversation

@pavankumar464

Copy link
Copy Markdown

No description provided.

Copilot AI review requested due to automatic review settings June 25, 2026 05:06
@pavankumar464 pavankumar464 requested review from a team as code owners June 25, 2026 05:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the WebUI upload attack-filter iptables chain to allow config-restore requests (POST /restoreConfig.jst) to pass through on specific device/product modes (CBR2, and OneStack business mode), avoiding the existing multipart/form-data and file-extension string drops.

Changes:

  • Adds an iptables exception rule for POST /restoreConfig.jst on _CBR2_PRODUCT_REQ_.
  • Adds an equivalent exception rule gated by is_devicemode_business() on _ONESTACK_PRODUCT_REQ_.
  • Introduces a forward declaration for is_devicemode_business() under _ONESTACK_PRODUCT_REQ_.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread source/firewall/firewall.c Outdated
Comment thread source/firewall/firewall.c Outdated
Copilot AI review requested due to automatic review settings June 25, 2026 06:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment thread source/firewall/Makefile.am
Comment thread source/firewall/firewall.c
Tighten the match to the HTTP request line by including the following " HTTP" token and limiting the search window to the beginning of the payload (e.g., --from 0 --to 64).

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 25, 2026 08:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread source/firewall/Makefile.am
Comment thread source/firewall/firewall.c Outdated
Copilot AI review requested due to automatic review settings June 29, 2026 04:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment thread source/firewall/Makefile.am Outdated
Comment thread source/firewall/firewall.c
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 29, 2026 08:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread source/firewall/firewall.c Outdated
Copilot AI review requested due to automatic review settings June 29, 2026 09:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants