RDKB-65487: Telemetry rdkcentral exposing comcast specific URL#386
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR sanitizes hard-coded endpoints in unit test profile JSON and makes CI test-result upload configurable via a repository secret, improving portability across environments.
Changes:
- Updated bulkdata datamodel unit tests to use
https://example.com/instead of a project-specific URL. - Updated L1/L2 GitHub Actions workflows to read the test-results upload endpoint from
secrets.TEST_RESULTS_PUSH_URL. - Added a guard to skip result upload when
TEST_RESULTS_PUSH_URLis not set.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
source/test/bulkdata/datamodelTest.cpp |
Replaces the hard-coded HTTP URL inside test profile JSON blobs with https://example.com/. |
.github/workflows/L1-tests.yml |
Makes the upload target configurable via TEST_RESULTS_PUSH_URL and skips upload when unset. |
.github/workflows/L2-tests.yml |
Makes the upload target configurable via TEST_RESULTS_PUSH_URL and skips upload when unset. |
AravindanNC
changed the title
shibu-kv
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Remove comcast specific URL and use mock URLs/Github secrets instead
Test Procedure: Make sure L1 and L2 tests work
Signed-off-by: nc.aravindan@gmail.com