VPAAMP-615 Writing to Local TSB stops in pause play pause sequence#1640
Open
hthakkar-synamedia wants to merge 2 commits into
Open
VPAAMP-615 Writing to Local TSB stops in pause play pause sequence#1640hthakkar-synamedia wants to merge 2 commits into
hthakkar-synamedia wants to merge 2 commits into
Conversation
When the local AAMP TSB is active, the live fetcher writes segments via
EnqueueWrite and does not consume slots from the GStreamer ring buffer.
However, the IsFragmentCacheFull() guard in DownloadFragment fired
unconditionally: with the pipeline paused, the inject thread was blocked,
no ring-buffer slot was ever freed, and DownloadsAreEnabled() remained
true — causing the while-loop to spin indefinitely.
Fix: Skip the ring-buffer wait when IsLocalAAMPTsbInjection() is true:
if (IsFragmentCacheFull() && !aamp->IsLocalAAMPTsbInjection())
Also adds L1 microtest to verify the fix
DomSyna
reviewed
Jun 23, 2026
DomSyna
reviewed
Jun 23, 2026
DomSyna
reviewed
Jun 23, 2026
DomSyna
reviewed
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the local AAMP TSB is active, the live fetcher writes segments via EnqueueWrite and does not consume slots from the GStreamer ring buffer. However, the IsFragmentCacheFull() guard in DownloadFragment fired unconditionally: with the pipeline paused, the inject thread was blocked, no ring-buffer slot was ever freed, and DownloadsAreEnabled() remained true — causing the while-loop to spin indefinitely.
Fix: Skip the ring-buffer wait when IsLocalAAMPTsbInjection() is true:
Also adds L1 microtest to verify the fix