Skip to content

Added Plugin and Interface rules for Thunder QA#286

Draft
workkavint-ship-it wants to merge 9 commits into
masterfrom
spec/plugin-qa-tool-integration
Draft

Added Plugin and Interface rules for Thunder QA#286
workkavint-ship-it wants to merge 9 commits into
masterfrom
spec/plugin-qa-tool-integration

Conversation

@workkavint-ship-it

@workkavint-ship-it workkavint-ship-it commented Jun 15, 2026

Copy link
Copy Markdown

PR Summary

This PR adds the rule reference documents that will be used as the basis for the automated Thunder QA checks:

  1. Plugin Rules (openspec/changes/thunder-plugin-qa/specs/plugin/Thunder-plugin-rules.md) – 79 plugin-related rules
  2. Interface Rules (openspec/changes/thunder-plugin-qa/specs/interface/Thunder-interface-rules.md) – 19 interface-related rules

If you think a rule should be added, removed, reworded, or have its severity changed, please edit the relevant .md file and push to this branch.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces an OpenSpec change bundle for a proposed “Thunder PluginQA” system, adding specification and planning documents for plugin/interface rule validation and CSV report generation.

Changes:

  • Added OpenSpec configuration plus a new change package (openspec/changes/thunder-plugin-qa/) containing proposal, design, tasks, and specs.
  • Added detailed rule reference documents for Thunder plugin rules (v3.3.0) and Thunder interface validation rules.
  • Added a report-generation spec describing CSV output formats for plugin and interface validation runs.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 16 comments.

Show a summary per file
File Description
openspec/config.yaml Adds baseline OpenSpec configuration stub (schema + optional context/rules sections).
openspec/changes/thunder-plugin-qa/tasks.md Adds a comprehensive implementation task breakdown for the PluginQA system.
openspec/changes/thunder-plugin-qa/specs/reports/spec.md Defines CSV report requirements/formatting for plugin & interface review outputs.
openspec/changes/thunder-plugin-qa/specs/plugin/Thunder-plugin-rules.md Adds the plugin rules reference document (v3.3.0) with 79 rules and examples.
openspec/changes/thunder-plugin-qa/specs/plugin/spec.md Adds the plugin validation delta/spec (folder structure, setup script behavior, rule loading).
openspec/changes/thunder-plugin-qa/specs/interface/Thunder-interface-rules.md Adds the interface validation rules reference document (core + advisory rules).
openspec/changes/thunder-plugin-qa/specs/interface/spec.md Adds the interface validation + plugin generation delta/spec (commands, setup, rule updates).
openspec/changes/thunder-plugin-qa/proposal.md Adds the PluginQA proposal and delivery structure overview.
openspec/changes/thunder-plugin-qa/design.md Adds the architecture/design document describing prompts, rule loading, reporting, and setup.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread openspec/changes/thunder-plugin-qa/specs/interface/Thunder-interface-rules.md Outdated
Comment thread openspec/changes/thunder-plugin-qa/specs/interface/spec.md Outdated
Comment thread openspec/changes/thunder-plugin-qa/specs/interface/spec.md Outdated
Comment thread openspec/changes/thunder-plugin-qa/specs/interface/spec.md Outdated
Comment thread openspec/changes/thunder-plugin-qa/specs/reports/spec.md Outdated
Comment thread openspec/changes/thunder-plugin-qa/design.md Outdated
Comment thread openspec/changes/thunder-plugin-qa/proposal.md Outdated
Comment thread openspec/changes/thunder-plugin-qa/specs/interface/spec.md Outdated
Comment thread openspec/changes/thunder-plugin-qa/specs/reports/spec.md Outdated
Comment thread openspec/changes/thunder-plugin-qa/proposal.md
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 11 comments.

Comment thread openspec/changes/thunder-plugin-qa/specs/plugin/spec.md Outdated
Comment thread openspec/changes/thunder-plugin-qa/specs/plugin/spec.md Outdated
Comment thread openspec/changes/thunder-plugin-qa/specs/plugin/spec.md Outdated
Comment thread openspec/changes/thunder-plugin-qa/specs/plugin/spec.md Outdated
Comment thread openspec/changes/thunder-plugin-qa/specs/interface/Thunder-interface-rules.md Outdated
Comment thread openspec/changes/thunder-plugin-qa/design.md Outdated
Comment thread openspec/changes/thunder-plugin-qa/tasks.md Outdated
Comment thread openspec/changes/thunder-plugin-qa/specs/interface/spec.md Outdated
Comment thread openspec/changes/thunder-plugin-qa/specs/interface/spec.md Outdated
Comment thread openspec/changes/thunder-plugin-qa/proposal.md
workkavint-ship-it and others added 2 commits June 15, 2026 19:46
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 10 comments.

Comment thread openspec/changes/thunder-plugin-qa/specs/plugin/spec.md
Comment thread openspec/changes/thunder-plugin-qa/specs/plugin/spec.md Outdated
Comment thread openspec/changes/thunder-plugin-qa/tasks.md Outdated
Comment thread openspec/changes/thunder-plugin-qa/tasks.md Outdated
Comment thread openspec/changes/thunder-plugin-qa/tasks.md Outdated
Comment thread openspec/changes/thunder-plugin-qa/specs/interface/Thunder-interface-rules.md Outdated
Comment thread openspec/changes/thunder-plugin-qa/specs/plugin/spec.md Outdated
Comment thread openspec/changes/thunder-plugin-qa/specs/plugin/spec.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Comment thread openspec/changes/thunder-plugin-qa/tasks.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 10 comments.

Comment thread openspec/changes/thunder-plugin-qa/tasks.md Outdated
Comment thread openspec/changes/thunder-plugin-qa/tasks.md Outdated
Comment thread openspec/changes/thunder-plugin-qa/specs/plugin/spec.md Outdated
Comment thread openspec/changes/thunder-plugin-qa/specs/plugin/spec.md
Comment thread openspec/changes/thunder-plugin-qa/specs/reports/spec.md
Comment thread openspec/changes/thunder-plugin-qa/design.md Outdated
Comment thread openspec/changes/thunder-plugin-qa/design.md Outdated
Comment thread openspec/changes/thunder-plugin-qa/specs/interface/spec.md
Comment thread openspec/changes/thunder-plugin-qa/specs/plugin/spec.md
Comment thread openspec/changes/thunder-plugin-qa/tasks.md
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@MFransen69 MFransen69 requested review from sebaszm and removed request for msieben June 16, 2026 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants