Remove Mockshell dependency from JSONRPC Functional Tests#278
Closed
smanes0213 wants to merge 5 commits into
Closed
Remove Mockshell dependency from JSONRPC Functional Tests#278smanes0213 wants to merge 5 commits into
smanes0213 wants to merge 5 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request replaces the JSON-RPC functional test server’s local MockShell stub with an embedded Thunder PluginHost via Thunder::TestCore::ThunderTestRuntime, so JSON-RPC dispatch runs against a real in-process IShell/PluginHost environment.
Changes:
- Removed the
MockShell-based setup and initializedThunderTestRuntimeinJsonRpcServer, attaching JSON-RPC to a realIShell. - Updated build configuration to enable Thunder’s test runtime and link JSON-RPC functional tests against the required Thunder test support library.
- Updated CI workflow packages/configuration to support building the embedded runtime during functional tests.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/FunctionalTests/README.md | Updates JSON-RPC functional test architecture documentation to describe using ThunderTestRuntime/real IShell. |
| tests/FunctionalTests/jsonrpc/MockShell.h | Removes the IShell stub previously used by the JSON-RPC functional tests. |
| tests/FunctionalTests/jsonrpc/JsonRpcServer.h | Adds ThunderTestRuntime and stores a real IShell proxy instead of MockShell. |
| tests/FunctionalTests/jsonrpc/JsonRpcServer.cpp | Initializes/deinitializes the embedded Thunder runtime and attaches/detaches JSON-RPC using a real shell. |
| tests/FunctionalTests/jsonrpc/CMakeLists.txt | Links JSON-RPC functional tests to thunder_test_support needed for the test runtime. |
| tests/FunctionalTests/external/thunder/CMakeLists.txt | Enables Thunder’s test runtime option when JSON-RPC tests are enabled. |
| .github/workflows/ProxyStubFunctionalTests.yml | Installs additional dependencies and enables test runtime in the workflow configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Closing this pull request as it is covered in PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the local mock shell based JSON-RPC test setup with Thunder test runtime integration so tests run against real in-process PluginHost behavior. JsonRpcServer now initializes ThunderTestRuntime, acquires a real IShell from the embedded host, and attaches JSON-RPC dispatch through that shell.