Skip to content

Arrow fix#94

Open
HalukaMB wants to merge 4 commits into
mainfrom
arrow-fix
Open

Arrow fix#94
HalukaMB wants to merge 4 commits into
mainfrom
arrow-fix

Conversation

@HalukaMB

@HalukaMB HalukaMB commented Dec 7, 2021

Copy link
Copy Markdown
Contributor

Can you please give me feedback whether you are happy with the result and also, how you would refactor the ArrowHead.tsx to make the functions more clear.

@sophiamersmann

Copy link
Copy Markdown
Member

Thank you! This works well but couldn't this be much simpler? To find a mid point on a line defined by two points, wouldn't you only need the distance between those points and then you can work with the ratio? I haven't tried, so I might be mistaken

@sophiamersmann

Copy link
Copy Markdown
Member

I think this line breaks the build:

import { args } from 'react';

args is likely a leftover from Storybook, it can be safely removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants