Check previous and next versions as well#136
Merged
rapids-bot[bot] merged 4 commits intoJun 26, 2026
Merged
Conversation
jameslamb
approved these changes
Jun 26, 2026
jameslamb
left a comment
jameslamb
left a comment
Member
There was a problem hiding this comment.
Seems fine to me, would just ask that you test this in https://github.com/rapidsai/cuml before we merge / release it.
Should just mean changing the repo to your fork, the rev to the latest commit from this PR, and running pre-commit run --all-files.
Member
Author
|
Good call, I found an unrelated bug: #137 |
Member
Author
|
After merging #137, the check passes on cuml. Merging. |
Member
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #122