Fix stain normalizer float dtype detection#1109
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix float input detection in
image_to_absorbanceso normalized floating-point images use the float clipping path.What changed
image.dtype.kind == "f"instead of comparing the dtype object to the string"f"float32andfloat64inputs intest_stain_normalizer.pysource_intensity=1.0, including lower-bound and upper-bound clippingWhy
image_to_absorbancereceivesimage.dtypeas a dtype object, so the oldinput_dtype == "f"check was always false.That sent float images through the integer clipping path. For normalized inputs, especially with
source_intensity=1.0, values below1.0were clipped incorrectly before the absorbance transform.Validation
stain_normalizer.pyimage_to_absorbancewithfloat32andfloat64inputspython3 -m py_compileon the changed source and test filescupyinstalled