Fix per-process image cache key equality#1108
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix per-process image cache key equality so entries with the same tile location but different file hashes do not alias.
What changed
file_hashandlocation_hashin the per-process cache key equality functorcucim_testsWhy
The per-process cache hash already mixed
file_hashandlocation_hash, but equality only comparedlocation_hash.That allowed different files or IFDs with matching tile coordinates to be treated as the same cache key, which could return the wrong cached tile or reject a valid insert as a duplicate.
Validation
FindCUDAToolkitfails to locatenvcc