Skip to content

chore: upgrade go-jose to v4 and update JWT serialization methods#2460

Open
chimanjain wants to merge 8 commits into
quay:mainfrom
chimanjain:upgrade-go-jose
Open

chore: upgrade go-jose to v4 and update JWT serialization methods#2460
chimanjain wants to merge 8 commits into
quay:mainfrom
chimanjain:upgrade-go-jose

Conversation

@chimanjain
Copy link
Copy Markdown
Contributor

chore: upgrade go-jose from v3 to v4 and update JWT serialization methods

@chimanjain chimanjain requested a review from a team as a code owner May 18, 2026 13:21
@chimanjain chimanjain requested review from crozzy and removed request for a team May 18, 2026 13:21
@crozzy
Copy link
Copy Markdown
Collaborator

crozzy commented May 18, 2026

This is a change that will take more effort on account of v4 enforcing a minimum key length. That means that if anyone has short keys configured in their environments in the wild auth will potentially fail:

{"level":"ERROR","source":"main.main.func3","time":"2026-05-18T10:05:15.476020329-07:00","msg":"error exit","reason":"go-jose/go-jose: invalid key size for algorithm"}

Potential additions:

  • Release notes and commit message should mention this
  • config/auth.go.validate should probably check key length
  • Edit local-dev/clair/config.yaml

@chimanjain
Copy link
Copy Markdown
Contributor Author

This is a change that will take more effort on account of v4 enforcing a minimum key length. That means that if anyone has short keys configured in their environments in the wild auth will potentially fail:

{"level":"ERROR","source":"main.main.func3","time":"2026-05-18T10:05:15.476020329-07:00","msg":"error exit","reason":"go-jose/go-jose: invalid key size for algorithm"}

Potential additions:

  • Release notes and commit message should mention this
  • config/auth.go.validate should probably check key length
  • Edit local-dev/clair/config.yaml

Thanks @crozzy . I'll add additional checks and update UT's. Please review once I commit them

Signed-off-by: Chiman Jain <chimanjain15@gmail.com>
Signed-off-by: Chiman Jain <chimanjain15@gmail.com>
Signed-off-by: Chiman Jain <chimanjain15@gmail.com>
…n/clair into upgrade-go-jose

Signed-off-by: Chiman Jain <chimanjain15@gmail.com>
Signed-off-by: Chiman Jain <chimanjain15@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants