Skip to content

FROMLIST: thermal: qcom: Add support for Qualcomm MBG thermal monitoring#664

Open
raryan-qcom wants to merge 2 commits into
qualcomm-linux:qcom-6.18.yfrom
raryan-qcom:for-mbgthermal
Open

FROMLIST: thermal: qcom: Add support for Qualcomm MBG thermal monitoring#664
raryan-qcom wants to merge 2 commits into
qualcomm-linux:qcom-6.18.yfrom
raryan-qcom:for-mbgthermal

Conversation

@raryan-qcom
Copy link
Copy Markdown

@raryan-qcom raryan-qcom commented Jun 5, 2026

This series adds support for Qualcomm MBG thermal monitoring.

Adding support for:

DT bindings for the MBG thermal monitor peripheral on PM8775
A new Qualcomm SPMI MBG thermal monitor driver under drivers/thermal/qcom/
The driver monitors die temperature alarms, handles the MBG interrupt on
upper-threshold violation, reads the fault status, and reports events to the
thermal framework.
Link: https://lore.kernel.org/all/20260601-spmi-mbg-driver-v1-0-b4892b55a17f@oss.qualcomm.com/
CRs-Fixed: 4561980
RFC patch:
https://lore.kernel.org/all/qq3cggafexwpdrv46eqijxfmrdbqusl2vpbuswqmcvshqueaiw@r4mrmap4nwkt/

Satya Priya Kakitapalli added 2 commits June 5, 2026 16:46
Add bindings for the Qualcomm MBG (Master Bandgap) temperature alarm peripheral
found on the PM8775 PMIC. Unlike the existing SPMI temp alarm peripheral,
the MBG peripheral supports both hot and cold threshold monitoring across
two programmable levels (LVL1 and LVL2), with interrupt status reported via
a fault status register over SPMI.

Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
Co-developed-by: Sachin Gupta <sachin.gupta@oss.qualcomm.com>
Signed-off-by: Sachin Gupta <sachin.gupta@oss.qualcomm.com>
Add driver for the Qualcomm MBG thermal monitoring device. It monitors
the die temperature, and when there is a level 1 upper threshold
violation, it receives an interrupt over spmi. The driver reads
the fault status register and notifies thermal accordingly.

Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
Co-developed-by: Sachin Gupta <sachin.gupta@oss.qualcomm.com>
Signed-off-by: Sachin Gupta <sachin.gupta@oss.qualcomm.com>
@raryan-qcom raryan-qcom requested review from a team, ndechesne, sgaud-quic and yijiyang June 5, 2026 11:18
@qswat-orbit-external
Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

1 similar comment
@qswat-orbit-external
Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qswat-orbit-external
Copy link
Copy Markdown

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4561965 on any of the following entities:

Entities:

  • kernel.qli.2.0

CR: 4561965

Please ensure the CR has a change task associated with at least one of the entities for this branch.

@qswat-orbit-external
Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4561980 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4561980
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

@raryan-qcom
Copy link
Copy Markdown
Author

raryan-qcom commented Jun 5, 2026

No checkpatch error were found. I ran the checkpatch on MakeFile also but it already had 74 warning even though we added one change. One mutex structure is added without comments, so checker is failing, requestion override now, in next time we will fix that. Please find below results of checkpatch for reference-

(venv) raryan@hu-raryan-hyd:/local/mnt/workspace/raryan/qli2.0/kernel$ ./checkpatch.pl --no-tree -g 12a244b

No typos will be found - file '/local/mnt/workspace/raryan/qli2.0/kernel/spelling.txt': No such file or directory
No structs that should be const will be found - file '/local/mnt/workspace/raryan/qli2.0/kernel/const_structs.checkpatch': No such file or directory
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#6:
Add bindings for the Qualcomm MBG (Master Bandgap) temperature alarm peripheral

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#37:
new file mode 100644

total: 0 errors, 2 warnings, 82 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

Commit 12a244b ("FROMLIST: dt-bindings: thermal: Add Qualcomm MBG thermal monitor support") has style problems, please review.

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
(venv) raryan@hu-raryan-hyd:/local/mnt/workspace/raryan/qli2.0/kernel$ ./checkpatch.pl --no-tree -g 6a1751c
No typos will be found - file '/local/mnt/workspace/raryan/qli2.0/kernel/spelling.txt': No such file or directory
No structs that should be const will be found - file '/local/mnt/workspace/raryan/qli2.0/kernel/const_structs.checkpatch': No such file or directory
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#55:
new file mode 100644

total: 0 errors, 1 warnings, 277 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

Commit 6a1751c ("FROMLIST: thermal: qcom: Add support for Qualcomm MBG thermal monitoring") has style problems, please review.

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
(venv) raryan@hu-raryan-hyd:/local/mnt/workspace/raryan/qli2.0/kernel$ ./checkpatch.pl -f drivers/thermal/q
qcom/ qoriq_thermal.c
(venv) raryan@hu-raryan-hyd:/local/mnt/workspace/raryan/qli2.0/kernel$ ./checkpatch.pl -f drivers/thermal/q
qcom/ qoriq_thermal.c
(venv) raryan@hu-raryan-hyd:/local/mnt/workspace/raryan/qli2.0/kernel$ ./checkpatch.pl -f drivers/thermal/qcom/qcom-spmi-mbg-tm.c
No typos will be found - file '/local/mnt/workspace/raryan/qli2.0/kernel/spelling.txt': No such file or directory
No structs that should be const will be found - file '/local/mnt/workspace/raryan/qli2.0/kernel/const_structs.checkpatch': No such file or directory
total: 0 errors, 0 warnings, 254 lines checked

@qswat-orbit-external
Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4561980 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4561980
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant