feat(moqsrc): add configurable max-latency-ms GObject property#12
feat(moqsrc): add configurable max-latency-ms GObject property#12JoaquinBCh wants to merge 3 commits into
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This pull request introduces a configurable max-latency-ms property to the MoqSrc GStreamer element, replacing the hardcoded 1-second latency limit for track consumers. The feedback points out that because settings are only resolved once at session startup, any runtime changes to max-latency-ms while the pipeline is active will be silently ignored. It is recommended to add a warning log if this property is modified during an active session to prevent confusion.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Summary
max-latency-msGObject property tomoqsrc(default: 1000ms)Duration::from_secs(1)in both video and audio track consumer creationg_object_setTest plan
libgstmoq.soand verify property is registered:gst-inspect-1.0 moqsrc | grep max-latencyg_object_set(src, "max-latency-ms", (guint64)70, NULL)and confirm no GLib critical warning(Written by Claude)