Skip to content

feat(moqsrc): add configurable max-latency-ms GObject property#12

Closed
JoaquinBCh wants to merge 3 commits into
benchmark-developfrom
feat/moqsrc-max-latency-ms
Closed

feat(moqsrc): add configurable max-latency-ms GObject property#12
JoaquinBCh wants to merge 3 commits into
benchmark-developfrom
feat/moqsrc-max-latency-ms

Conversation

@JoaquinBCh

Copy link
Copy Markdown

Summary

  • Adds max-latency-ms GObject property to moqsrc (default: 1000ms)
  • Parametrizes the hardcoded Duration::from_secs(1) in both video and audio track consumer creation
  • Allows callers to tune buffer drop behavior per subscriber instance via g_object_set

Test plan

  • Build libgstmoq.so and verify property is registered: gst-inspect-1.0 moqsrc | grep max-latency
  • Set property from C: g_object_set(src, "max-latency-ms", (guint64)70, NULL) and confirm no GLib critical warning

(Written by Claude)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a configurable max-latency-ms property to the MoqSrc GStreamer element, replacing the hardcoded 1-second latency limit for track consumers. The feedback points out that because settings are only resolved once at session startup, any runtime changes to max-latency-ms while the pipeline is active will be silently ignored. It is recommended to add a warning log if this property is modified during an active session to prevent confusion.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread rs/moq-gst/src/source/imp.rs Outdated
@JoaquinBCh JoaquinBCh requested a review from santi-ferreiro June 8, 2026 13:50
@JoaquinBCh JoaquinBCh closed this Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant