Open
Conversation
Commit 56db30e made Message generic, but left EmailMessage inheriting from bare MIMEPart. Propagate the same type parameters to EmailMessage so it is typed consistently, and add a regression test case covering the generic EmailMessage behavior.
This comment has been minimized.
This comment has been minimized.
Commit 56db30e made Message generic and switched get_body() and iter_parts() to return MIMEPart[_HeaderRegistryT]. That dropped the second type parameter, so the header parameter type defaulted to Any. Preserve both type parameters in the return types and add a regression test covering get_body() and iter_parts().
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 56db30e made Message generic,
but left EmailMessage inheriting from bare MIMEPart.
Propagate the same type parameters to EmailMessage so it is typed
consistently, and add a regression test case covering the generic
EmailMessage behavior.