GH-148294: Make configure found g++ correctly#148298
Open
sendaoYan wants to merge 2 commits intopython:mainfrom
Open
GH-148294: Make configure found g++ correctly#148298sendaoYan wants to merge 2 commits intopython:mainfrom
sendaoYan wants to merge 2 commits intopython:mainfrom
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Author
I think this PR do not impact on Python users. The renson shows in PR description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
There is a bug in configure.ac when try to find the c++ compiler. The AC_PATH_TOOL autoconf macro usage should be like below:
Before this PR, AC_PATH_TOOL was invoked with duplicated prog-to-check-for parameter, this will cause the forth parameter
[notfound]treated as g++ search path. So configure shell script can not find the g++ through search pathnotfound.This PR fix the bug in configure.ac. and re-generate configure through autoconf 2.72.
After this PR, the configure log snippet shows below:
This PR do not change the hehavior. This PR only avoid the annoying configure warning. Before this PR configure select g++ as c++ compiler, after this PR configure select /usr/bin/g++ as the c++ compiler. g++ and /usr/bing++ is the same binary actually on my machine.
AC_PATH_TOOLinconfigure.acfor finding compilers #148294