Skip to content

GH-148294: Make configure found g++ correctly#148298

Open
sendaoYan wants to merge 2 commits intopython:mainfrom
sendaoYan:issue-148294
Open

GH-148294: Make configure found g++ correctly#148298
sendaoYan wants to merge 2 commits intopython:mainfrom
sendaoYan:issue-148294

Conversation

@sendaoYan
Copy link
Copy Markdown

@sendaoYan sendaoYan commented Apr 9, 2026

Hi all,

There is a bug in configure.ac when try to find the c++ compiler. The AC_PATH_TOOL autoconf macro usage should be like below:

AC_PATH_TOOL(variable, prog-to-check-for, [value-if-not-found], [path = '$PATH'])

Before this PR, AC_PATH_TOOL was invoked with duplicated prog-to-check-for parameter, this will cause the forth parameter [notfound] treated as g++ search path. So configure shell script can not find the g++ through search path notfound.

This PR fix the bug in configure.ac. and re-generate configure through autoconf 2.72.

After this PR, the configure log snippet shows below:

checking for g++... /usr/bin/g++
configure:

  By default, distutils will build C++ extension modules with "/usr/bin/g++".
  If this is not intended, then set CXX on the configure command line.

This PR do not change the hehavior. This PR only avoid the annoying configure warning. Before this PR configure select g++ as c++ compiler, after this PR configure select /usr/bin/g++ as the c++ compiler. g++ and /usr/bing++ is the same binary actually on my machine.

@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Apr 9, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Apr 9, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@python-cla-bot
Copy link
Copy Markdown

python-cla-bot bot commented Apr 9, 2026

All commit authors signed the Contributor License Agreement.

CLA signed

@sendaoYan
Copy link
Copy Markdown
Author

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

I think this PR do not impact on Python users. The renson shows in PR description.

@aisk aisk added the skip news label Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants