Improve render async fragment utility#60
Open
yunusemredilber wants to merge 2 commits intopuzzle-js:masterfrom
Open
Improve render async fragment utility#60yunusemredilber wants to merge 2 commits intopuzzle-js:masterfrom
yunusemredilber wants to merge 2 commits intopuzzle-js:masterfrom
Conversation
yunusemredilber
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Background
In the most recent revisions, #57, we enhanced our gateway queries. Although there is one public function—the "renderAsyncFragment" function—we use it for on-demand fragments. To further tune fragment queries, we added the option to specify an optional gateway name. However, this circumstance only happens if a page has two fragments with the same name. I, therefore, see a chance to streamline API by simply confirming the existence of the if attribute and its value.