Skip to content

refactor(ui): reorganize finding detail drawer#11091

Open
HugoPBrito wants to merge 6 commits intomasterfrom
refactor/ui-finding-drawer-reorg
Open

refactor(ui): reorganize finding detail drawer#11091
HugoPBrito wants to merge 6 commits intomasterfrom
refactor/ui-finding-drawer-reorg

Conversation

@HugoPBrito
Copy link
Copy Markdown
Member

Context

The finding detail drawer mixed status, identifiers, and remediation guidance in a single tab, with the resource info squeezed into a 4-column grid that left little room for long resource names. This PR reorganizes the drawer to surface the most important context first and frees real estate for the resource block.

Description

  • New status banner above the resource info, colored by finding status (PASS/MANUAL/FAIL and MUTED); MUTED uses a neutral box and MANUAL a slightly lighter orange in dark mode.
  • Risk loses its red Card and renders as a left-accent block; Description and Remediation recommendation are plain sections.
  • Dedicated Remediation tab; "Other Findings For This Resource" renamed to Findings for this resource; IDs (Check ID / Finding ID / Finding UID) moved to the end of Finding Overview.
  • Resource info grid migrated to container queries: row 1 is Account (2/5) + Resource (3/5) with the View Resource link inline next to the UID; row 2 is Last detected · First seen · Failing for · Service · Region in 5 equal columns. Removes Group and Resource type.
  • Scans tab now lays out Started At / Completed At / Launched At in a single 3-column grid (no orphan column for the optional Scheduled At).
  • FindingResourceRow carries statusExtended, populated by findingToFindingResourceRow and the finding-group resources adapter, so the status banner renders without waiting for the full finding fetch.
  • Card gains success and warning variants matching the existing danger styling, and EntityInfo accepts an idAction slot for inline actions next to the UID.

Steps to review

  1. cd ui && pnpm install && pnpm run dev
  2. Open any finding from a finding group or the findings table → drawer should show:
    • Status banner above the resource block colored by status
    • Account on the left, Resource on the right with View Resource link next to the UID
    • Tabs: Finding Overview, Remediation, Findings for this resource, Scans, Events
  3. Trigger a MANUAL finding → banner uses the lighter orange.
  4. Open a MUTED finding → banner uses the neutral grey.
  5. Carousel-navigate inside the drawer → Status Extended renders immediately from the row data.

Checklist

Community Checklist
  • This feature/issue is listed in here or roadmap.prowler.com
  • Is it assigned to me, if not, request it via the issue/feature in here or Prowler Community Slack

UI

  • All issue/task requirements work as expected on the UI
  • Screenshots/Video - Mobile (X < 640px)
  • Screenshots/Video - Tablet (640px > X < 1024px)
  • Screenshots/Video - Desktop (X > 1024px)
  • Ensure new entries are added to ui/CHANGELOG.md

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

HugoPBrito added 5 commits May 8, 2026 12:27
- Mirror danger styling with green (pass) and orange (warning)
- Apply matching default md padding via compound variants
- Render an inline action element next to the entity ID/UID
- Used by the finding drawer to attach a View Resource link
- Add optional statusExtended to FindingResourceRow
- Propagate it from finding props and finding-group resources adapters
- Lets the drawer render the status banner without waiting for the
  full finding fetch
- Status Extended rendered as a colored banner (success/warning/danger
  by status, lighter MANUAL bg) above the resource info
- Risk shown as a left-accent block; Description and Remediation
  recommendation as plain sections
- Dedicated Remediation tab; rename Other Findings tab to
  Findings for this resource; IDs moved to the end of Finding Overview
- Resource info grid uses container queries: Account 2/5 + Resource 3/5
  with inline View Resource action; row 2 lays out Last detected,
  First seen, Failing for, Service, Region in 5 equal columns
- Remove Group and Resource type fields from the resource info grid
- Scans tab combines date fields into a single 3-column grid
- Update tests and skeleton to match the new layout
@HugoPBrito HugoPBrito requested a review from a team as a code owner May 8, 2026 11:33
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

✅ All necessary CHANGELOG.md files have been updated.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

Conflict Markers Resolved

All conflict markers have been successfully resolved in this pull request.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

🔒 Container Security Scan

Image: prowler-ui:3ed0a22
Last scan: 2026-05-08 11:37:09 UTC

📊 Vulnerability Summary

Severity Count
🔴 Critical 2
Total 2

2 package(s) affected

⚠️ Action Required

Critical severity vulnerabilities detected. These should be addressed before merging:

  • Review the detailed scan results
  • Update affected packages to patched versions
  • Consider using a different base image if updates are unavailable

📋 Resources:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant