refactor(ui): reorganize finding detail drawer#11091
Open
HugoPBrito wants to merge 6 commits intomasterfrom
Open
refactor(ui): reorganize finding detail drawer#11091HugoPBrito wants to merge 6 commits intomasterfrom
HugoPBrito wants to merge 6 commits intomasterfrom
Conversation
- Mirror danger styling with green (pass) and orange (warning) - Apply matching default md padding via compound variants
- Render an inline action element next to the entity ID/UID - Used by the finding drawer to attach a View Resource link
- Add optional statusExtended to FindingResourceRow - Propagate it from finding props and finding-group resources adapters - Lets the drawer render the status banner without waiting for the full finding fetch
- Status Extended rendered as a colored banner (success/warning/danger by status, lighter MANUAL bg) above the resource info - Risk shown as a left-accent block; Description and Remediation recommendation as plain sections - Dedicated Remediation tab; rename Other Findings tab to Findings for this resource; IDs moved to the end of Finding Overview - Resource info grid uses container queries: Account 2/5 + Resource 3/5 with inline View Resource action; row 2 lays out Last detected, First seen, Failing for, Service, Region in 5 equal columns - Remove Group and Resource type fields from the resource info grid - Scans tab combines date fields into a single 3-column grid - Update tests and skeleton to match the new layout
Contributor
|
✅ All necessary |
Contributor
|
✅ Conflict Markers Resolved All conflict markers have been successfully resolved in this pull request. |
Contributor
🔒 Container Security ScanImage: 📊 Vulnerability Summary
2 package(s) affected
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The finding detail drawer mixed status, identifiers, and remediation guidance in a single tab, with the resource info squeezed into a 4-column grid that left little room for long resource names. This PR reorganizes the drawer to surface the most important context first and frees real estate for the resource block.
Description
PASS/MANUAL/FAILandMUTED);MUTEDuses a neutral box andMANUALa slightly lighter orange in dark mode.FindingResourceRowcarriesstatusExtended, populated byfindingToFindingResourceRowand the finding-group resources adapter, so the status banner renders without waiting for the full finding fetch.successandwarningvariants matching the existingdangerstyling, andEntityInfoaccepts anidActionslot for inline actions next to the UID.Steps to review
cd ui && pnpm install && pnpm run devView Resourcelink next to the UIDMANUALfinding → banner uses the lighter orange.MUTEDfinding → banner uses the neutral grey.Checklist
Community Checklist
UI
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.