Do not fail the test suite for a remote server that is down.#1329
Merged
Do not fail the test suite for a remote server that is down.#1329
Conversation
The test suite may fail if the resolver at identifiers.org is down, because the test for IdentifiersDotOrg performs a live call to that server to ensure that we can resolve identifiers using that service. The proper solution here would be to mock the identifiers.org service in the test suite, so that the test suite is completely independent of the remote service, but for now, we will at least detect whether the resolution failure is explained by a HTTP error, and if so we simply skip the test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test suite may fail if the resolver at identifiers.org is down, because the test for IdentifiersDotOrg performs a live call to that server to ensure that we can resolve identifiers using that service.
The proper solution here would be to mock the identifiers.org service in the test suite, so that the test suite is completely independent of the remote service, but for now, we will at least detect whether the resolution failure is explained by a HTTP error, and if so we simply skip the test.