Could edu.stanford.protege:protege-launcher:5.6.0-beta-1-SNAPSHOT drop off redundant dependencies?#1051
Open
Celebrate-future wants to merge 1 commit intoprotegeproject:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I found the pom file of project edu.stanford.protege:protege-launcher:5.6.0-beta-1-SNAPSHOT introduced 60 dependencies. However, among them, 4 libraries (6%) are not used by your project. I list the redundant dependencies below (labelled as red ones in the figure):
Redundant dependencies
org.apache.servicemix.bundles:org.apache.servicemix.bundles.javax-inject:jar:1_2:compile
com.google.errorprone:error_prone_annotations:jar:2.4.0:compile
com.google.code.findbugs:jsr305:jar:3.0.1:compile
org.slf4j:jul-to-slf4j:jar:1.7.12:compile
Outdated dependencies
org.apache.servicemix.bundles:org.apache.servicemix.bundles.javax-inject:1_2 (4198 days without maintenance)
org.slf4j:jul-to-slf4j:1.7.12 (3047 days without maintenance)
Removing the redundant dependencies can reduce the size of project and prevent potential dependency conflict issues (i.e., multiple versions of the same library). More importantly, 2 of the redundant dependencies org.apache.servicemix.bundles:org.apache.servicemix.bundles.javax-inject:jar:1_2:compile, com.google.code.findbugs:jsr305:jar:3.0.1:compile induced dependency conflict in the dependency graph. As such, I suggest a refactoring operation for edu.stanford.protege:protege-launcher:5.6.0-beta-1-SNAPSHOT’s pom file.
The attached PR helps resolve the reported problem. It is safe to remove the unused libraries (we considered Java reflection relations when analyzing the dependencies). These changes have passed edu.stanford.protege:protege-launcher:5.6.0-beta-1-SNAPSHOT’s maven tests.
Best regards