test: drive middleware via django.test.Client#3
Open
marcin-prerender wants to merge 1 commit into
Open
Conversation
RequestFactory bypasses MIDDLEWARE ordering and URL resolution, so the prior tests could pass even if the middleware was missing from settings or registered in the wrong position. Register PrerenderMiddleware in tests/settings.MIDDLEWARE, add a tests/urls.py with a catch-all view, and switch to Client().get/post so each request runs the full Django pipeline. Also covers the X-Bufferbot and POST-pass-through cases the previous test suite was missing. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #1 (
add-prerender-django). Will auto-retarget tomainonce #1 merges.What
Replace
RequestFactory(which bypasses MIDDLEWARE ordering and URL resolution) with the fulldjango.test.Client. RegisterPrerenderMiddlewareintests/settings.MIDDLEWARE, add a catch-alltests/urls.py, and switch each test toclient.get/post.Why
RequestFactoryconstructs request objects and hands them straight to the middleware callable. That lets tests pass even if:settings.MIDDLEWARESecurityMiddlewareorSessionMiddlewarein a way that breaks orderingROOT_URLCONFwasn't reachableThe new
Clientsetup runs each request through the actual Django pipeline.Coverage
Adds two scenarios the previous file was missing —
X-Bufferbotheader and POST pass-through — to align with the other integrations.Local run:
pytest→ 13 passed (7 middleware-via-Client + 6 contract).🤖 Generated with Claude Code