Skip to content

Migrate CI to GitHub Actions#5544

Open
emilykl wants to merge 13 commits intomainfrom
migrate-ci-to-gh-actions
Open

Migrate CI to GitHub Actions#5544
emilykl wants to merge 13 commits intomainfrom
migrate-ci-to-gh-actions

Conversation

@emilykl
Copy link
Copy Markdown
Contributor

@emilykl emilykl commented Mar 26, 2026

Link to issue

Closes #5239

Description of change

Migrate remaining CircleCI workflows to GitHub Actions.

All existing jobs/steps/workflows have been migrated, EXCEPT for the Build HTML figures (Pandas 1) and compare step in the Percy workflow. This test was failing on GHA due to some small floating-point differences between Numpy 1 and 2, and I don't think it's a very relevant test anymore, so I just decided to remove it entirely.

Demo

N/A

Testing strategy

Check that all CI jobs are passing and manually verify that all workflow steps have been migrated.

Additional information (optional)

Guidelines

@emilykl emilykl marked this pull request as draft March 26, 2026 20:18
@emilykl emilykl changed the title first draft Migrate CI to GitHub Actions Mar 27, 2026
@emilykl emilykl force-pushed the migrate-ci-to-gh-actions branch 5 times, most recently from 89169c3 to 5bb6069 Compare March 30, 2026 19:12
@emilykl emilykl force-pushed the migrate-ci-to-gh-actions branch from 4587573 to 5e1e0ec Compare April 3, 2026 16:27
@emilykl emilykl force-pushed the migrate-ci-to-gh-actions branch from 812bbf3 to 20c54eb Compare April 7, 2026 19:55
@emilykl emilykl marked this pull request as ready for review April 7, 2026 20:00
@emilykl emilykl requested review from camdecoster April 8, 2026 18:16
@emilykl
Copy link
Copy Markdown
Contributor Author

emilykl commented Apr 8, 2026

@camdecoster FYI I believe these "pending" old CircleCI checks are showing up due to the "Require status checks to pass before merging" rule for main.

Once this PR is merged, we can update that rule and those old checks should stop showing up.

Screenshot 2026-04-08 at 2 18 35 PM

camdecoster
camdecoster previously approved these changes Apr 10, 2026
Copy link
Copy Markdown
Contributor

@camdecoster camdecoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments about structure, but this looks fine to me.

node-version: "22"
- name: Install dependencies
run: |
curl -LsSf https://astral.sh/uv/install.sh | sh
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an official Astral action to install uv which might be a better option.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good tip, we should probably use that one then.

Comment on lines +27 to +30
- name: Set up Chrome
uses: browser-actions/setup-chrome@v2.1.1
with:
install-chromedriver: true
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use a composite action to handle the browser set up.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually did, but forgot to update this usage here. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

move from Circle CI to GitHub Actions

2 participants