Conversation
89169c3 to
5bb6069
Compare
4587573 to
5e1e0ec
Compare
812bbf3 to
20c54eb
Compare
|
@camdecoster FYI I believe these "pending" old CircleCI checks are showing up due to the "Require status checks to pass before merging" rule for Once this PR is merged, we can update that rule and those old checks should stop showing up.
|
camdecoster
left a comment
There was a problem hiding this comment.
I left a few comments about structure, but this looks fine to me.
.github/workflows/build-package.yml
Outdated
| node-version: "22" | ||
| - name: Install dependencies | ||
| run: | | ||
| curl -LsSf https://astral.sh/uv/install.sh | sh |
There was a problem hiding this comment.
There's an official Astral action to install uv which might be a better option.
There was a problem hiding this comment.
Oh good tip, we should probably use that one then.
| - name: Set up Chrome | ||
| uses: browser-actions/setup-chrome@v2.1.1 | ||
| with: | ||
| install-chromedriver: true |
There was a problem hiding this comment.
You could use a composite action to handle the browser set up.
There was a problem hiding this comment.
I actually did, but forgot to update this usage here. Thanks!

Link to issue
Closes #5239
Description of change
Migrate remaining CircleCI workflows to GitHub Actions.
All existing jobs/steps/workflows have been migrated, EXCEPT for the
Build HTML figures (Pandas 1) and comparestep in the Percy workflow. This test was failing on GHA due to some small floating-point differences between Numpy 1 and 2, and I don't think it's a very relevant test anymore, so I just decided to remove it entirely.Demo
N/A
Testing strategy
Check that all CI jobs are passing and manually verify that all workflow steps have been migrated.
Additional information (optional)
Guidelines