Skip to content

Fix fastapi websocket #3734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
T4rk1n wants to merge 2 commits into
base: v4.2
Choose a base branch
from
+2 −7
Open

Fix fastapi websocket #3734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9e23cc
fix fastapi websocket
T4rk1n Apr 10, 2026
0af47f1
remove leftover prints
T4rk1n Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions dash/backends/_fastapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,7 @@ async def _handle_error(

async def __call__(self, scope: Scope, receive: Receive, send: Send) -> None:
# Handle lifespan events (startup/shutdown)

if scope["type"] == "lifespan":
try:
dash_app = get_app()
Expand All @@ -199,7 +200,7 @@ async def __call__(self, scope: Scope, receive: Receive, send: Send) -> None:
return

# Non-HTTP/WebSocket scopes pass through
if scope["type"] not in ("http", "websocket"):
if scope["type"] != "http":
await self.app(scope, receive, send)
return

Expand Down Expand Up @@ -298,7 +299,6 @@ def setup_catchall(self, dash_app: Dash):

def _setup_catchall(self):
try:
print("Setting up catch-all route for unmatched paths", file=sys.stderr)
dash_app = get_app()

async def catchall(_request: Request):
Expand All @@ -317,10 +317,6 @@ def add_url_rule(
methods: list[str] | None = None,
include_in_schema: bool = False,
):
print(
f"Adding URL rule: {rule} -> {view_func} (endpoint: {endpoint}, methods: {methods})",
file=sys.stderr,
)
if rule == "":
rule = "/"
if isinstance(view_func, str):
Expand Down
1 change: 0 additions & 1 deletion dash/dash.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,7 +637,6 @@ def __init__( # pylint: disable=too-many-statements, too-many-branches
self._got_first_request = {"pages": False, "setup_server": False}

if server:
print(f"init app from server {server}")
self.init_app()

self.logger.setLevel(logging.INFO)
Expand Down
Loading