Fix issue with shallowEquals incorrectly returning too early#319
Open
ice1080 wants to merge 1 commit into
Open
Fix issue with shallowEquals incorrectly returning too early#319ice1080 wants to merge 1 commit into
shallowEquals incorrectly returning too early#319ice1080 wants to merge 1 commit into
Conversation
|
Author
|
Note that this is a minor fix until @abstrakt8 has time to work on #298 , as the changes in that also fix this bug |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shallowEqualshas a minor bug in it that causes it to return too early if a prop has anequalsmethod on it. This means that the order that props are defined causes them to change the rerender behavior (e.g. if prop 2 changes but prop 1 doesn't change,shallowEqualssays they are the same and things are not rerendered).The comment above the
forloop saysall keys, so it should loop through all keys before returning thatobjAandobjBare equal. Change the method to returnfalseif props are unequal, otherwise finish the loop before returningtrue.