ci: fix first-time contributor welcome check#6929
Open
Yashagarwal9798 wants to merge 2 commits into
Open
Conversation
Signed-off-by: Yashagarwal9798 <yashagarwal9798@gmail.com>
Contributor
Author
|
@Warashi @Ayushmore1214 @rahulshendre Could you please review this PR? |
Member
|
@Yashagarwal9798 could you run this once locally and drop a screenshot here ? |
Contributor
Author
|
@Ayushmore1214 I tested it in my fork by opening a test PR from Since the fixed workflow was on the base branch, the 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Fixes the first-time contributor welcome workflow to correctly check pull requests opened by the PR author.
It now uses GitHub search with
author:<username>instead of the unsupportedcreatorparameter.Why we need it:
The old check could look at unrelated recent pull requests and incorrectly skip the welcome comment.
This ensures first-time contributors get the welcome message on their first pull request.
Which issue(s) this PR fixes:
Fixes #6918
Does this PR introduce a user-facing change?:
No.
Users are not affected. This only changes a GitHub Actions workflow.
No.
No migration is needed.