fix(deploymentstore): return oldest uncompleted deployment as head#6921
Open
AruneshDwivedi wants to merge 1 commit into
Open
fix(deploymentstore): return oldest uncompleted deployment as head#6921AruneshDwivedi wants to merge 1 commit into
AruneshDwivedi wants to merge 1 commit into
Conversation
The head deployment selection in ListAppHeadDeployments was inverted. The previous loop order (pendings -> planneds -> runnings) caused newer statuses to overwrite older ones, so the newest uncompleted deployment was returned instead of the oldest. Fix: iterate runnings first (oldest), then planneds and pendings only if no entry exists for that application ID. This matches the Lister interface docstring: 'Head deployment is same with the oldest uncompleted one.' Fixes pipe-cd#6780 Signed-off-by: Arunesh Dwivedi <arunesh.devops@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The head deployment selection in ListAppHeadDeployments was returning the newest instead of the oldest uncompleted deployment.
The previous loop order (pendings -> planneds -> runnings) caused newer statuses to overwrite older ones. For an app with both a pending and a running deployment, the running one won -- the opposite of what the Lister interface docstring promises.
Fix: iterate runnings first (oldest status), then planneds and pendings only if no entry already exists for that application ID.
Both piped and pipedv1 stores are fixed. Fixes #6780