Add view My Ideas sort option to quick links

Fix tests

Author: iMattPro

controller/base.php

@@ -144,5 +144,6 @@ protected function display_search_ideas()
 			'S_SEARCHBOX_ACTION'	=> append_sid("{$this->root_path}search.{$this->php_ext}"),
 			'S_SEARCH_IDEAS_HIDDEN_FIELDS'	=> build_hidden_fields(array('fid' => array($this->config['ideas_forum_id']))),
 		));
+			'U_SEARCH_MY_IDEAS' 	=> $this->helper->route('phpbb_ideas_list_controller', ['sort' => ideas::SORT_MYIDEAS, 'status' => '-1']),
 	}
 }

factory/ideas.php

@@ -26,6 +26,7 @@ class ideas
 	const SORT_TITLE = 'title';
 	const SORT_TOP = 'top';
 	const SORT_VOTES = 'votes';
+	const SORT_MYIDEAS = 'egosearch';
 	const SUBJECT_LENGTH = 120;
 
 	/** @var array Idea status names and IDs */
@@ -198,6 +199,11 @@ protected function query_sort($sort, $direction)
 				$this->sql['ORDER_BY'] = 'i.idea_votes_up + i.idea_votes_down ' . $direction;
 			break;
 
+			case self::SORT_MYIDEAS:
+				$this->sql['WHERE'][] = 'i.idea_author = ' . (int) $this->user->data['user_id'];
+				$this->sql['ORDER_BY'] = "i.idea_date DESC";
+			break;
+
 			case self::SORT_TOP:
 				$this->sql['WHERE'][] = 'i.idea_votes_up > i.idea_votes_down';
 			// no break

styles/prosilver/template/event/navbar_header_quick_links_before.html

@@ -0,0 +1,7 @@
+{% if S_REGISTERED_USER and U_SEARCH_MY_IDEAS %}
+	<li>
+		<a href="{{ U_SEARCH_MY_IDEAS }}" role="menuitem">
+			<i class="icon fa-lightbulb-o fa-fw icon-gray" aria-hidden="true"></i><span>{{ lang('LIST_EGOSEARCH') }}</span>
+		</a>
+	</li>
+{% endif %}

tests/controller/list_controller_test.php

@@ -140,6 +140,19 @@ public function controller_test_data()
 					'status' => \phpbb\ideas\factory\ideas::$statuses,
 				),
 			),
+			// My ideas list
+			array(
+				200,
+				'list_body.html',
+				array(
+					'sort' => \phpbb\ideas\factory\ideas::SORT_MYIDEAS,
+					'status' => -1,
+				),
+				array(
+					'sort' => \phpbb\ideas\factory\ideas::SORT_MYIDEAS,
+					'status' => \phpbb\ideas\factory\ideas::$statuses,
+				),
+			),
 		);
 	}
 

tests/functional/ideas_test.php

@@ -53,25 +53,38 @@ public function test_new_idea()
 	 */
 	public function test_view_ideas_lists()
 	{
-		// Access new ideas list
+		// Test new ideas list
 		$crawler = self::request('GET', "app.php/ideas/list?sid={$this->sid}");
 		$this->assertContainsLang('OPEN_IDEAS', $crawler->filter('h2')->text());
 		$this->assertNotContainsLang('NO_IDEAS_DISPLAY', $crawler->filter('.topiclist.forums')->text());
 
-		// Access top ideas list
+		// Test top ideas list
 		$crawler = self::request('GET', "app.php/ideas/list/top?sid={$this->sid}");
-		$this->assertContainsLang('TOP_IDEAS', $crawler->filter('h2')->text());
+		$this->assertContainsLang('LIST_TOP', $crawler->filter('h2')->text());
 		$this->assertNotContainsLang('NO_IDEAS_DISPLAY', $crawler->filter('.topiclist.forums')->text());
 
-		// Access all ideas list
+		// Test all ideas list
 		$crawler = self::request('GET', "app.php/ideas/list/date?status=-1&sid={$this->sid}");
 		$this->assertContainsLang('ALL_IDEAS', $crawler->filter('h2')->text());
 		$this->assertNotContainsLang('NO_IDEAS_DISPLAY', $crawler->filter('.topiclist.forums')->text());
 
-		// Access implemented ideas list (should be empty list)
+		// Test implemented ideas list (should be empty list)
 		$crawler = self::request('GET', "app.php/ideas/list/date?status=3&sid={$this->sid}");
-		$this->assertContainsLang('IMPLEMENTED', $crawler->filter('h2')->text());
+		$this->assertContainsLang('LIST_IMPLEMENTED', $crawler->filter('h2')->text());
 		$this->assertContainsLang('NO_IDEAS_DISPLAY', $crawler->filter('.topiclist.forums')->text());
+
+		// Test my ideas list is empty when logged out
+		$crawler = self::request('GET', "app.php/ideas/list/egosearch?status=-1&sid={$this->sid}");
+		$this->assertNotContainsLang('LIST_EGOSEARCH', $crawler->filter('#quick-links')->text());
+		$this->assertContainsLang('LIST_EGOSEARCH', $crawler->filter('h2')->text());
+		$this->assertContainsLang('NO_IDEAS_DISPLAY', $crawler->filter('.topiclist.forums')->text());
+
+		// Test my ideas list works when logged in
+		$this->login();
+		$crawler = self::request('GET', "app.php/ideas/list/egosearch?status=-1&sid={$this->sid}");
+		$this->assertContainsLang('LIST_EGOSEARCH', $crawler->filter('#quick-links')->text());
+		$this->assertContainsLang('LIST_EGOSEARCH', $crawler->filter('h2')->text());
+		$this->assertNotContainsLang('NO_IDEAS_DISPLAY', $crawler->filter('.topiclist.forums')->text());
 	}
 
 	/**