Refactor how ideas list pages are named

Author: iMattPro

controller/list_controller.php

@@ -52,22 +52,16 @@ public function ideas_list($sort)
 			$sort = ideas::SORT_DATE;
 		}
 
-		// if sort by "implemented", sort ideas with status implemented by date
-		if ($sort === ideas::SORT_IMPLEMENTED)
-		{
-			$status = ideas::$statuses['IMPLEMENTED'];
-			$sort = ideas::SORT_DATE;
-		}
-
-		// Set the status name for displaying in the template
-		$status_name = (!$status && $sort === ideas::SORT_TOP) ? $this->language->lang('TOP_IDEAS') : $this->ideas->get_status_from_id($status);
+		// Set the name for displaying in the template
+		$status_name = 'LIST_' . strtoupper($status > 0 ? array_search($status, ideas::$statuses) : $sort);
+		$status_name = $this->language->is_set($status_name) ? $this->language->lang($status_name) : '';
 
 		// For special case where we want to request ALL ideas,
 		// including the statuses normally hidden from lists.
 		if ($status === -1)
 		{
 			$status = ideas::$statuses;
-			$status_name = $this->language->lang('ALL_IDEAS');
+			$status_name = $status_name ?: $this->language->lang('ALL_IDEAS');
 		}
 
 		// Generate ideas

factory/ideas.php

@@ -21,7 +21,6 @@ class ideas
 {
 	const SORT_AUTHOR = 'author';
 	const SORT_DATE = 'date';
-	const SORT_IMPLEMENTED = 'implemented';
 	const SORT_NEW = 'new';
 	const SORT_SCORE = 'score';
 	const SORT_TITLE = 'title';

language/en/common.php

@@ -55,6 +55,14 @@
 	'JS_DISABLED'           => 'JavaScript is disabled',
 
 	'LATEST_IDEAS'			=> 'Latest Ideas',
+	'LIST_DUPLICATE'  		=> 'Duplicate ideas',
+	'LIST_EGOSEARCH'		=> 'My ideas',
+	'LIST_IMPLEMENTED' 		=> 'Implemented ideas',
+	'LIST_IN_PROGRESS' 		=> 'In Progress ideas',
+	'LIST_INVALID'    		=> 'Invalid ideas',
+	'LIST_NEW'				=> 'New ideas',
+	'LIST_TOP'				=> 'Top ideas',
+
 	'LOGGED_OUT'			=> 'You must be logged in to do this.',
 
 	'NEW'					=> 'New',

tests/controller/list_controller_test.php

@@ -52,8 +52,8 @@ public function controller_test_data()
 				200,
 				'list_body.html',
 				array(
-					'sort' => \phpbb\ideas\factory\ideas::SORT_IMPLEMENTED,
-					'status' => 0,
+					'sort' => \phpbb\ideas\factory\ideas::SORT_DATE,
+					'status' => \phpbb\ideas\factory\ideas::$statuses['IMPLEMENTED'],
 				),
 				array(
 					'sort' => \phpbb\ideas\factory\ideas::SORT_DATE,