Rename function for search vars to common display vars

Author: iMattPro

controller/base.php

@@ -133,17 +133,18 @@ protected function assign_template_block_vars($block, $rows)
 	}
 
 	/**
-	 * Assign template variables for a search ideas field
+	 * Assign common template variables for Ideas pages
 	 *
 	 * @return void
 	 */
-	protected function display_search_ideas()
+	protected function display_common_vars()
 	{
-		$this->template->assign_vars(array(
+		$this->template->assign_vars([
 			'S_DISPLAY_SEARCHBOX'	=> (bool) $this->auth->acl_get('u_search') && $this->auth->acl_get('f_search', $this->config['ideas_forum_id']) && $this->config['load_search'],
 			'S_SEARCHBOX_ACTION'	=> append_sid("{$this->root_path}search.{$this->php_ext}"),
-			'S_SEARCH_IDEAS_HIDDEN_FIELDS'	=> build_hidden_fields(array('fid' => array($this->config['ideas_forum_id']))),
-		));
+			'S_SEARCH_IDEAS_HIDDEN_FIELDS'	=> build_hidden_fields(['fid' => [$this->config['ideas_forum_id']]]),
+
 			'U_SEARCH_MY_IDEAS' 	=> $this->helper->route('phpbb_ideas_list_controller', ['sort' => ideas::SORT_MYIDEAS, 'status' => '-1']),
+		]);
 	}
 }

controller/index_controller.php

@@ -57,8 +57,8 @@ public function index()
 			'FORUM_NAME'		=> $this->language->lang('IDEAS'),
 		));
 
-		// Display the search ideas field
-		$this->display_search_ideas();
+		// Display common ideas template vars
+		$this->display_common_vars();
 
 		return $this->helper->render('index_body.html', $this->language->lang('IDEAS_TITLE'));
 	}

controller/list_controller.php

@@ -112,8 +112,8 @@ public function ideas_list($sort)
 			$start
 		);
 
-		// Display the search ideas field
-		$this->display_search_ideas();
+		// Display common ideas template vars
+		$this->display_common_vars();
 
 		return $this->helper->render('list_body.html', $this->language->lang('IDEA_LIST'));
 	}