Try to use out_length for bound fetched values#68
Merged
Conversation
I have no idea why it's using strlen in the first place, but if SQL/CLI returns junk in the buffer, then the length might be correct. This matches what we did with column names on IBM i. The SQL_BINARY case is more puzzling, but we can take a look at it later if this works for strings. Why is it ifdef'd to use strlen/out_length depending on platform?
Member
Author
|
This does seem to resolve the issue the user was having on IBM i after some testing. I suspect binaries should be covered under this too (considering those are supposed to be able to tolerate nulls)... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have no idea why it's using strlen in the first place, but if SQL/CLI returns junk in the buffer, then the length might be correct. This matches what we did with column names on IBM i.
The SQL_BINARY case is more puzzling, but we can take a look at it later if this works for strings. Why is it ifdef'd to use strlen/out_length depending on platform?