fix: correct domain reference in ADAE example comments (#163)#164
Open
LeonidasZhak wants to merge 1 commit into
Open
fix: correct domain reference in ADAE example comments (#163)#164LeonidasZhak wants to merge 1 commit into
LeonidasZhak wants to merge 1 commit into
Conversation
The comment 'Join ADSL variables with VS' incorrectly references the VS (Vital Signs) domain. Since this is the ADAE (Adverse Events) example, the comment should reference the AE domain instead. Fixes pharmaverse#163
bms63
approved these changes
Jun 7, 2026
bms63
left a comment
bms63
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the quick fix!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Corrects a comment typo in the ADAE example files where the domain reference was incorrectly set to VS (Vital Signs) instead of AE (Adverse Events).
Changes
Context
The ADAE example joins ADSL variables with the AE domain (adverse events), not the VS domain (vital signs). The ADVS example files correctly reference VS. This is a comment-only fix with no functional impact.
Fixes #163