Fix zlib-compressed ASS dialogue forwarding from Matroska#85
Open
rubinaboobin3-cell wants to merge 1 commit into
Open
Fix zlib-compressed ASS dialogue forwarding from Matroska#85rubinaboobin3-cell wants to merge 1 commit into
rubinaboobin3-cell wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes ASS/SSA subtitle rendering for Matroska files whose ASS dialogue payloads are zlib-compressed.
The previous overlay path forwarded dialogue bytes using:
That works for plain text ASS payloads, but fails for zlib-compressed payloads. Compressed data may contain embedded NUL bytes, and Media3's subtitle sample limit can represent a truncated text-like slice instead of the full compressed payload. Passing only
sample.limit() - lineIndexcan therefore send an incomplete compressed stream to libass.Fix
AssTrackOutputnow:AssHandler.readTrackDialogue,sample.limit()behavior for normal uncompressed ASS payloads,Why
Without this, affected fansub MKVs can show symptoms such as:
The important detail is that zlib inflation must use the full raw sample backing buffer / actual block payload, not the truncated
subtitleSample.limit()slice.Scope
This change is limited to the Media3 Matroska ASS forwarding path in:
lib_ass_media/src/main/java/io/github/peerless2012/ass/media/text/AssTrackOutput.ktIt does not change renderer selection, overlay behavior, font handling, or normal uncompressed ASS forwarding.
Testing
This was validated downstream in an app using libass-android with a Matroska sample containing zlib-compressed ASS dialogue packets. Before the fix, dialogue and signs were missing or broken. After inflating from the full raw sample buffer, dialogue, signs, and effects rendered correctly.