[codex] Add robust exec-chain profiling support#46
Open
wangyinz wants to merge 9 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exec*,fexecve,execveat,posix_spawn, andposix_spawnppaths.peak_fini()before exec.envpby injecting/de-duplicatingLD_PRELOADand propagating missingPEAK_*variables when enabled.syscall(SYS_execve/SYS_execveat)so raw syscall callers do not silently bypass the exec-chain path.PEAK_EXEC_CHAIN,PEAK_EXEC_CHECKPOINT,PEAK_EXEC_PROPAGATE_PEAK_ENV, andPEAK_EXEC_TRACE_PATH.Root Causes Addressed
LD_PRELOADandPEAK_*, preventing the replacement image from being profiled.timer_createsymbol; the signal policy now resolves the GLIBC_2.3.3 interface.Validation
346/346 passed.test_cuda_interceptor_consistencypassed;git diff --checkclean.hpc-test: job791735,COMPLETED 0:0, exec-chain smoke passed.hpc-test: job7832267,COMPLETED 0:0.hpc-test: exec checkpoint tests passed; one unrelated strict-detach MPI test failed, consistent with pre-existing broad-suite noise.hpc-test: job7832231failed47/216, used as evidence that remaining broad-suite failures are not introduced by this branch.Review
Three independent final review rounds completed with no blockers found.